Skip to content
Permalink
Browse files

Customize: Safeguard a check on the `customize_validate_{$setting_id}…

…` filter value to ensure it is a `WP_Error`.

While the filter is documented to only support a `WP_Error`, it has been a common practice to return true in a validation function if no errors have occurred. This was already caught when the same filter was executed in `WP_Customize_Setting`, it was however missing in `WP_Customize_Manager::validate_setting_values()`.

Props flixos90.

Merges [43578] to the 5.0 branch.
Fixes #44809.

git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44392 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information...
desrosj committed Jan 4, 2019
1 parent 5340afd commit 45a8f1d7c566178b4bcb03284bcbb704477dbc1c
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/wp-includes/class-wp-customize-manager.php
@@ -2284,7 +2284,7 @@ public function validate_setting_values( $setting_values, $options = array() ) {
if ( ! is_wp_error( $validity ) ) {
/** This filter is documented in wp-includes/class-wp-customize-setting.php */
$late_validity = apply_filters( "customize_validate_{$setting->id}", new WP_Error(), $unsanitized_value, $setting );
if ( ! empty( $late_validity->errors ) ) {
if ( is_wp_error( $late_validity ) && ! empty( $late_validity->errors ) ) {
$validity = $late_validity;
}
}

0 comments on commit 45a8f1d

Please sign in to comment.
You can’t perform that action at this time.