Skip to content
Permalink
Browse files

Menus: Fix the Custom Links text fallback.

When adding a Custom Link and leaving the "Link Text" field empty, WordPress used to set a default fallback text: "Menu Item".

The changes in [36379] broke this behavior making the fallback text: `(Pending)`, with a leading space.

Pending major refactoring of the Menus page (which is going to use a block-based user interface) this change just restores the original behavior by adding the fallback text to the related AJAX response.

Props christophherr, Fencer04, thakkarhardik, backermann1978, audrasjb.
Merges [45727] to the 5.2 branch.
Fixes #38415.

git-svn-id: https://develop.svn.wordpress.org/branches/5.2@45828 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information...
SergeyBiryukov committed Aug 19, 2019
1 parent 08e8361 commit 469e5fdeca10d55e6268053bdd09b9b8e40b787e
Showing with 1 addition and 0 deletions.
  1. +1 −0 src/wp-admin/includes/ajax-actions.php
@@ -1423,6 +1423,7 @@ function wp_ajax_add_menu_item() {
$menu_obj = get_post( $menu_item_id );
if ( ! empty( $menu_obj->ID ) ) {
$menu_obj = wp_setup_nav_menu_item( $menu_obj );
$menu_obj->title = empty( $menu_obj->title ) ? __( 'Menu Item' ) : $menu_obj->title;
$menu_obj->label = $menu_obj->title; // don't show "(pending)" in ajax-added items
$menu_items[] = $menu_obj;
}

0 comments on commit 469e5fd

Please sign in to comment.
You can’t perform that action at this time.