Skip to content
Permalink
Browse files

Date/Time: In `wp_insert_post()`, when checking the post date to set …

…`future` or `publish` status, use string comparison to work around far future dates (year 2038+) on 32-bit systems.

Props Rarst, nofearinc.
Fixes #25347.

git-svn-id: https://develop.svn.wordpress.org/trunk@45851 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information...
SergeyBiryukov committed Aug 19, 2019
1 parent 0f8ba2c commit 896da178e017b8c967efe96f0d7fbb0a28b3157f
Showing with 26 additions and 6 deletions.
  1. +5 −6 src/wp-includes/post.php
  2. +21 −0 tests/phpunit/tests/post/wpInsertPost.php
@@ -3663,14 +3663,13 @@ function wp_insert_post( $postarr, $wp_error = false ) {
}
if ( 'attachment' !== $post_type ) {
if ( 'publish' == $post_status ) {
$now = gmdate( 'Y-m-d H:i:59' );
if ( mysql2date( 'U', $post_date_gmt, false ) > mysql2date( 'U', $now, false ) ) {
if ( 'publish' === $post_status ) {
// String comparison to work around far future dates (year 2038+) on 32-bit systems.
if ( $post_date_gmt > gmdate( 'Y-m-d H:i:59' ) ) {
$post_status = 'future';
}
} elseif ( 'future' == $post_status ) {
$now = gmdate( 'Y-m-d H:i:59' );
if ( mysql2date( 'U', $post_date_gmt, false ) <= mysql2date( 'U', $now, false ) ) {
} elseif ( 'future' === $post_status ) {
if ( $post_date_gmt <= gmdate( 'Y-m-d H:i:59' ) ) {
$post_status = 'publish';
}
}
@@ -302,4 +302,25 @@ function test_administrator_cannot_set_post_slug_on_post_type_they_cannot_publis
$this->assertSame( $expected, $actual );
}
/**
* @ticket 25347
*/
function test_scheduled_post_with_a_past_date_should_be_published() {
$now = new DateTimeImmutable( 'now', new DateTimeZone( 'UTC' ) );
$post_id = $this->factory()->post->create( [
'post_date_gmt' => $now->modify( '-1 year' )->format( 'Y-m-d H:i:s' ),
'post_status' => 'future',
] );
$this->assertEquals( 'publish', get_post_status( $post_id ) );
$post_id = $this->factory()->post->create( [
'post_date_gmt' => $now->modify( '+50 years' )->format( 'Y-m-d H:i:s' ),
'post_status' => 'future',
] );
$this->assertEquals( 'future', get_post_status( $post_id ) );
}
}

0 comments on commit 896da17

Please sign in to comment.
You can’t perform that action at this time.