Skip to content
Permalink
Browse files

Accessibility: Comments: Replace `@` with `at` in the displayed date …

…format.

The `@` symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates.

Props birgire, afercia, audrasjb, SergeyBiryukov.
Fixes #47893.

git-svn-id: https://develop.svn.wordpress.org/trunk@46084 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information...
SergeyBiryukov committed Sep 8, 2019
1 parent acadc5c commit 8aa380cf54a3e44740e9be223b490a12c6797035
@@ -209,6 +209,7 @@
__( '%1$s at %2$s' ),
/* translators: Comment date format. See https://secure.php.net/date */
get_comment_date( __( 'Y/m/d' ), $comment ),
/* translators: Comment time format. See https://secure.php.net/date */
get_comment_date( __( 'g:i a' ), $comment )
);
if ( 'approved' === wp_get_comment_status( $comment ) && ! empty( $comment->comment_post_ID ) ) {
@@ -103,16 +103,19 @@

<div class="misc-pub-section curtime misc-pub-curtime">
<?php
/* translators: Publish box date format, see https://secure.php.net/date */
$datef = __( 'M j, Y @ H:i' );
$submitted = sprintf(
/* translators: 1: Comment date, 2: Comment time. */
__( '%1$s at %2$s' ),
/* translators: Publish box date format, see https://secure.php.net/date */
date_i18n( _x( 'M j, Y', 'publish box date format' ), strtotime( $comment->comment_date ) ),
/* translators: Publish box time format, see https://secure.php.net/date */
date_i18n( _x( 'H:i', 'publish box time format' ), strtotime( $comment->comment_date ) )
);
?>
<span id="timestamp">
<?php
printf(
/* translators: %s: Comment date. */
__( 'Submitted on: %s' ),
'<b>' . date_i18n( $datef, strtotime( $comment->comment_date ) ) . '</b>'
);
/* translators: %s: Comment date. */
printf( __( 'Submitted on: %s' ), '<b>' . $submitted . '</b>' );
?>
</span>
<a href="#edit_timestamp" class="edit-timestamp hide-if-no-js"><span aria-hidden="true"><?php _e( 'Edit' ); ?></span> <span class="screen-reader-text"><?php _e( 'Edit date and time' ); ?></span></a>
@@ -867,6 +867,7 @@ public function column_date( $comment ) {
__( '%1$s at %2$s' ),
/* translators: Comment date format. See https://secure.php.net/date */
get_comment_date( __( 'Y/m/d' ), $comment ),
/* translators: Comment time format. See https://secure.php.net/date */
get_comment_date( __( 'g:i a' ), $comment )
);
@@ -1615,7 +1615,7 @@ function wp_default_scripts( &$scripts ) {
array(
'submittedOn' => __( 'Submitted on:' ),
/* translators: 1: Month, 2: Day, 3: Year, 4: Hour, 5: Minute. */
'dateFormat' => __( '%1$s %2$s, %3$s @ %4$s:%5$s' ),
'dateFormat' => __( '%1$s %2$s, %3$s at %4$s:%5$s' ),
)
);

0 comments on commit 8aa380c

Please sign in to comment.
You can’t perform that action at this time.