From d935e0c94ac239e7c479e0a45028bfdca869bc09 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Fri, 4 Jun 2021 23:12:56 +0000 Subject: [PATCH] REST API: Restore the `$creating` parameter of `rest_after_save_widget` action. This is consistent with other similar REST API actions. Partially reverts [51071], except for DocBlock formatting fixes. Props TimothyBlynJacobs. See #53317. git-svn-id: https://develop.svn.wordpress.org/trunk@51074 602fd350-edb4-49c9-b593-d223f7449a82 --- .../endpoints/class-wp-rest-widgets-controller.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/wp-includes/rest-api/endpoints/class-wp-rest-widgets-controller.php b/src/wp-includes/rest-api/endpoints/class-wp-rest-widgets-controller.php index be84173feb0c..29daf4b1d9da 100644 --- a/src/wp-includes/rest-api/endpoints/class-wp-rest-widgets-controller.php +++ b/src/wp-includes/rest-api/endpoints/class-wp-rest-widgets-controller.php @@ -414,14 +414,14 @@ protected function save_widget( $request, $sidebar_id ) { $id_base = $parsed_id['id_base']; $number = isset( $parsed_id['number'] ) ? $parsed_id['number'] : null; $widget_object = $wp_widget_factory->get_widget_object( $id_base ); - $update = true; + $creating = false; } elseif ( $request['id_base'] ) { // Saving a new widget. $id_base = $request['id_base']; $widget_object = $wp_widget_factory->get_widget_object( $id_base ); $number = $widget_object ? next_widget_id_number( $id_base ) : null; $id = $widget_object ? $id_base . '-' . $number : $id_base; - $update = false; + $creating = true; } else { return new WP_Error( 'rest_invalid_widget', @@ -525,9 +525,9 @@ protected function save_widget( $request, $sidebar_id ) { * @param string $id ID of the widget being saved. * @param string $sidebar_id ID of the sidebar containing the widget being saved. * @param WP_REST_Request $request Request object. - * @param bool $update Whether this is an existing widget being updated. + * @param bool $creating True when creating a widget, false when updating. */ - do_action( 'rest_after_save_widget', $id, $sidebar_id, $request, $update ); + do_action( 'rest_after_save_widget', $id, $sidebar_id, $request, $creating ); return $id; }