Skip to content
Permalink
Branch: master
Commits on Aug 23, 2019
  1. Build Tools: Pass the LOCAL_DIR environment variable through to the p…

    pento committed Aug 23, 2019
    …hpunit Docker container.
    
    This allows code running inside the container to know whether it's supposed to be running in `build` or `src`.
    
    See #47767.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45885 602fd350-edb4-49c9-b593-d223f7449a82
Commits on Aug 22, 2019
  1. Build Tools: Don't use git for package installs.

    pento committed Aug 22, 2019
    While NPM supports installing packages from git locations, this requires `git` to be in the path, which won't necessarily be true, particularly on Windows.
    
    We can download the release versions for these packages, instead.
    
    Fixes #47916.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45875 602fd350-edb4-49c9-b593-d223f7449a82
Commits on Aug 19, 2019
  1. Tests: Add an xdebug group for tests that require xdebug.

    pento committed Aug 19, 2019
    These tests are now also run as their own part of the Travis build, to ensure performance of other tests isn't affected by the presence of xdebug.
    
    Fixes #40532.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45827 602fd350-edb4-49c9-b593-d223f7449a82
Commits on Aug 16, 2019
  1. Build Tools: Improve `local-env` start behaviour under Docker Toolbox.

    pento committed Aug 16, 2019
    Docker Toolbox requires port forwarding to be configured, but generates error when trying to forward a port that's already been taken.
    
    This change removes clashing port forwarding rules before adding our own.
    
    See #47767.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45819 602fd350-edb4-49c9-b593-d223f7449a82
Commits on Aug 15, 2019
  1. Schema: Add an index to `wp_options.autoload`.

    pento committed Aug 15, 2019
    Most sites will be unaffected by this change, but those with a large number of rows in `wp_options`, only a small number of which have `autoload` set, will see a significant performance improvement.
    
    Sites with a large number of rows in `wp_options`, with many of them having `autoload` set will unfortunately see a performance penalty on top of the already very slow queries they're running, but this should be the minority of cases.
    
    Props DanBUK.
    Fixes #24044.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45805 602fd350-edb4-49c9-b593-d223f7449a82
  2. Build Tools: Change the PHPUnit Docker image's working directory to m…

    pento committed Aug 15, 2019
    …atch the other images.
    
    Also, pass the `WP_MULTISITE` environment variable along to the container.
    
    See #47767.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45800 602fd350-edb4-49c9-b593-d223f7449a82
Commits on Aug 14, 2019
  1. Build Tools: Run `composer` commands in a Docker container on Travis.

    pento committed Aug 14, 2019
    This tidies up the `.travis.yml` file a little more.
    
    See #47767.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45799 602fd350-edb4-49c9-b593-d223f7449a82
Commits on Aug 12, 2019
  1. Build Tools: Remove the old `docker-compose.yml` file, now no longer …

    pento committed Aug 12, 2019
    …used.
    
    See #47767.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45785 602fd350-edb4-49c9-b593-d223f7449a82
  2. Build Tools: Add the `docker-compose.yml` file, missed in [45783].

    pento committed Aug 12, 2019
    See #47767.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45784 602fd350-edb4-49c9-b593-d223f7449a82
  3. Build Tools: Miscellaneous `local-env` improvements.

    pento committed Aug 12, 2019
    - Move the functionality for controlling `local-env` out of `package.json`, into JS scripts.
    - Merge the `docker-compose` config files, and move it to the root directory. This allows `docker-compose.override.yml` to work for local overrides.
    - Fix nginx redirecting to port 80 under some circumstances.
    - `npm run env:install` now creates `wp-tests.config.php` for you.
    - Cleaned up a bunch of cruft in `.travis.yml`.
    
    See #47767.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45783 602fd350-edb4-49c9-b593-d223f7449a82
Commits on Aug 9, 2019
  1. Feeds: Introduce the `get_self_link()` function.

    pento committed Aug 9, 2019
    Corresponds to the `self_link()` template function.
    
    This matches other feed template functions, using one function to get the value, and a different function to echo it.
    
    Props jojotjebaby, mobeen-abdullah, donmhico, audrasjb, dshanske.
    Fixes #44838.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45772 602fd350-edb4-49c9-b593-d223f7449a82
Commits on Aug 8, 2019
  1. Emoji: Upgrade Twemoji to 12.1.2.

    pento committed Aug 8, 2019
    This upgrade adds support for the transgender flag: 🏳️‍⚧️
    
    There's some additional housekeeping in this commit:
    
    - Twemoji recently rearranged their repository and package, so `Gruntfile.js` needed tweaking to allow for that.
    - As only new files were added in this Twemoji release, the CDN version didn't need updating.
    
    Fixes #47852.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45769 602fd350-edb4-49c9-b593-d223f7449a82
Commits on Aug 7, 2019
  1. Build Tools: Switch all Travis PHPUnit jobs over to Docker-based PHP.

    pento committed Aug 7, 2019
    Additionally, there are a handful of related minor changes in this commit:
    - `.travis.yml` has been tidied up a little.
    - [45745] was incorrectly marking Travis jobs as passed when some PHPUnit runs failed.
    - Add the `LOCAL_PHP_MEMCACHED` environment variable, for enabling Memcached.
    - Add the `env:pull` NPM script, for refreshing Docker images.
    
    See #47767.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45762 602fd350-edb4-49c9-b593-d223f7449a82
Commits on Aug 5, 2019
  1. Build Tools: Add a WordPress Development Environment.

    pento committed Aug 5, 2019
    This commit adds the first iteration of a Docker-based config for setting up a local WordPress development environment.
    
    Props pento, noisysocks, mcsf, pbearne, isabel_brison.
    See #47767.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45745 602fd350-edb4-49c9-b593-d223f7449a82
Commits on Jul 19, 2019
  1. Coding Standards: Move the remaining PHPCS errors to report as warnin…

    pento committed Jul 19, 2019
    …gs, and add Travis tests.
    
    The remaining error-level coding standards issues (specifically, associated with the sniffs `WordPress.PHP.YodaConditions.NotYoda`, `WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase`, `WordPress.DB.PreparedSQL.InterpolatedNotPrepared`, `WordPress.DB.PreparedSQL.NotPrepared`, and `WordPress.Files.FileName.InvalidClassFileName`) are marked as warnings, until they're all addressed.
    
    This change allows us to run linting on Travis across the entire codebase, ensuring no other error-level violations can be introduced.
    
    Additionally, PHPCS will now cache results locally, drastically improving performance for subsequent checks: scanning the entire codebase takes 1-2 minutes the first time, and less than one second for subsequent checks.
    
    See #47632.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45665 602fd350-edb4-49c9-b593-d223f7449a82
  2. Coding Standards: Fix a filename replacement missed in [45663].

    pento committed Jul 19, 2019
    See #47632.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45664 602fd350-edb4-49c9-b593-d223f7449a82
  3. Coding Standards: Move `wp-includes/class-oembed.php` to `wp-includes…

    pento committed Jul 19, 2019
    …/class-wp-oembed.php`.
    
    This renames the file containing the `WP_oEmbed` class to conform to the coding standards.
    
    This commit also includes:
    
    - A new `class-oembed.php` that includes the new file, for anyone that may've been including the file directly.
    - Replaces references to the old filename with the new filename.
    
    See #47632.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45663 602fd350-edb4-49c9-b593-d223f7449a82
  4. Coding Standards: Move wp-admin/custom-background.php to wp-admin/inc…

    pento committed Jul 19, 2019
    …ludes/class-custom-background.php
    
    This renames the file containing the Custom_Background class to conform to the coding standards.
    
    This commit also includes:
    
    - A new custom-background.php that includes the new file, for anyone that may've been including the file directly.
    - Replaces a reference to the old filename with the new filename.
    
    See #47632.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45662 602fd350-edb4-49c9-b593-d223f7449a82
  5. Coding Standards: Exclude a handful of incorrectly named files that w…

    pento committed Jul 19, 2019
    …on't be renamed.
    
    See #47632.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45661 602fd350-edb4-49c9-b593-d223f7449a82
  6. Coding Standards: Improve spacing of `printf()` calls in the admin Ab…

    pento committed Jul 19, 2019
    …out pages.
    
    Props garrett-eclipse.
    Fixes #47734.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45660 602fd350-edb4-49c9-b593-d223f7449a82
Commits on Jul 18, 2019
  1. Customizer: Show all widgets when the search field is cleared.

    pento committed Jul 18, 2019
    When clicking the clear button on the widget search field, the search results should refresh to show all widgets.
    
    Props Mahesh901122.
    Fixes #47534.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45658 602fd350-edb4-49c9-b593-d223f7449a82
Commits on Jul 17, 2019
  1. Coding Standards: Move `wp-admin/custom-header.php` to `wp-admin/incl…

    pento committed Jul 17, 2019
    …udes/class-custom-image-header.php`
    
    This renames the file containing the `Custom_Image_Header` class to conform to the coding standards.
    
    This commit also includes:
    - A new `custom-header.php` that includes the new file, for anyone that may've been including the file directly.
    - Replaces references to the old filename with the new filename.
    
    See #47632.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45654 602fd350-edb4-49c9-b593-d223f7449a82
  2. Coding Standards: Exclude some class names from checks when they can'…

    pento committed Jul 17, 2019
    …t be renamed.
    
    Renaming the classes would likely cause back compat issues, so the safest option is to allow this handful to continue unchanged.
    
    See #47632.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45653 602fd350-edb4-49c9-b593-d223f7449a82
Commits on Jul 15, 2019
  1. Code Modernisation: Revert [45624].

    pento committed Jul 15, 2019
    Changing the method signatures on `Walker` causes back compat issues.
    
    See #47678.
    
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45640 602fd350-edb4-49c9-b593-d223f7449a82
  2. Code Modernisation: Fix known instances of array access on data types…

    pento committed Jul 15, 2019
    … that can't be accessed as arrays.
    
    PHP 7.4 addes a warning when trying access a null/bool/int/float/resource (everything but array, string and object) as if it were an array.
    
    This change fixes all of these warnings visible in unit tests.
    
    Props jrf.
    See #47704.
    
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45639 602fd350-edb4-49c9-b593-d223f7449a82
  3. Code Modernisation: Document when the Hash polyfills can be removed.

    pento committed Jul 15, 2019
    The Hash extension cannot be disabled as of PHP 7.4. So, while we can't remove these polyfills yet, we can document when we'll be able to.
    
    Props jrf.
    Fixes #47698.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45638 602fd350-edb4-49c9-b593-d223f7449a82
  4. Code Modernisation: Remove the SPL autoloader polyfill.

    pento committed Jul 15, 2019
    As of PHP 5.3, the SPL extension cannot be disabled, so we no longer need this polyfill.
    
    The file is kept with a `_deprecated_file()` call, to alert any plugins or themes that may be loading it directly.
    
    Props jrf, ayeshrajans.
    See #47698, #46630.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45637 602fd350-edb4-49c9-b593-d223f7449a82
  5. Code Modernisation: Remove the `array_replace_recursive()` polyfill.

    pento committed Jul 15, 2019
    This function was added in PHP 5.3.0, so we no longer need the polyfill.
    
    Props jrf.
    See #47698.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45636 602fd350-edb4-49c9-b593-d223f7449a82
  6. WPDB: Allow custom data to be added to logged queries.

    pento committed Jul 15, 2019
    This adds a new method, `wpdb::log_query()`, and a new filter, `log_query_custom_data`. The custom data is stored as a new element in each entry of the `wpdb::$queries` array.
    
    Props CrazyJaco, johnbillion, pento.
    Fixes 42151.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45635 602fd350-edb4-49c9-b593-d223f7449a82
Commits on Jul 12, 2019
  1. Code Modernisation: Introduce the spread operator in `wpdb::prepare()`.

    pento committed Jul 12, 2019
    Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
    
    Props jrf.
    See #47678.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45630 602fd350-edb4-49c9-b593-d223f7449a82
  2. Code Modernisation: Introduce the spread operator in `widgets.php`.

    pento committed Jul 12, 2019
    Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
    
    Props jrf.
    See #47678.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45629 602fd350-edb4-49c9-b593-d223f7449a82
  3. Code Modernisation: Introduce the spread operator in `theme.php`.

    pento committed Jul 12, 2019
    Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
    
    Props jrf, pento.
    See #47678.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45628 602fd350-edb4-49c9-b593-d223f7449a82
  4. Code Modernisation: Introduce the spread operator in `walk_page_dropd…

    pento committed Jul 12, 2019
    …own_tree()`.
    
    Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
    
    Props jrf.
    See #47678.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45627 602fd350-edb4-49c9-b593-d223f7449a82
  5. Code Modernisation: Introduce the spread operator in `add_post_type_s…

    pento committed Jul 12, 2019
    …upport()`.
    
    Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
    
    Props jrf, pento.
    See #47678.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45625 602fd350-edb4-49c9-b593-d223f7449a82
Commits on Jul 11, 2019
  1. Code Modernisation: Introduce the spread operator in `Walker`.

    pento committed Jul 11, 2019
    Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
    
    Props jrf.
    See #47678.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@45624 602fd350-edb4-49c9-b593-d223f7449a82
Older
You can’t perform that action at this time.