From 1dc6027c95d924de95ffe44c0270f9cbb0edf823 Mon Sep 17 00:00:00 2001 From: Dominik Schilling Date: Tue, 15 Jul 2025 10:28:51 +0200 Subject: [PATCH 01/20] Update heading --- src/wp-admin/includes/ms.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wp-admin/includes/ms.php b/src/wp-admin/includes/ms.php index 10ed2e27692e0..ba0bc3ce6333d 100644 --- a/src/wp-admin/includes/ms.php +++ b/src/wp-admin/includes/ms.php @@ -865,7 +865,7 @@ function confirm_delete_users( $users ) { return false; } ?> -

+

From 07b440b4c7a887d8b7cd95ec16f22d033e6b925a Mon Sep 17 00:00:00 2001 From: Dominik Schilling Date: Tue, 15 Jul 2025 10:33:48 +0200 Subject: [PATCH 02/20] Remove default selected option --- src/wp-admin/includes/ms.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wp-admin/includes/ms.php b/src/wp-admin/includes/ms.php index ba0bc3ce6333d..0fcbebfa76f7e 100644 --- a/src/wp-admin/includes/ms.php +++ b/src/wp-admin/includes/ms.php @@ -963,7 +963,7 @@ function confirm_delete_users( $users ) { printf( __( 'Site: %s' ), $user_site ); ?> -
  • From b06f7ebbe26fa6915d7d0791e0b0550406d160bd Mon Sep 17 00:00:00 2001 From: Dominik Schilling Date: Tue, 15 Jul 2025 11:10:32 +0200 Subject: [PATCH 03/20] Typecast allusers parameter and reuse variable --- src/wp-admin/includes/ms.php | 3 +-- src/wp-admin/network/users.php | 5 +++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/wp-admin/includes/ms.php b/src/wp-admin/includes/ms.php index 0fcbebfa76f7e..1a32405aa82f1 100644 --- a/src/wp-admin/includes/ms.php +++ b/src/wp-admin/includes/ms.php @@ -882,8 +882,7 @@ function confirm_delete_users( $users ) { ?> '; - confirm_delete_users( $_POST['allusers'] ); + confirm_delete_users( $allusers ); echo ''; require_once ABSPATH . 'wp-admin/admin-footer.php'; From d5783eada5e5d0571c2683278a73dbc62a23eb5e Mon Sep 17 00:00:00 2001 From: Dominik Schilling Date: Tue, 15 Jul 2025 11:11:01 +0200 Subject: [PATCH 04/20] Add TODO --- src/wp-admin/includes/ms.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/wp-admin/includes/ms.php b/src/wp-admin/includes/ms.php index 1a32405aa82f1..3553f43afa93a 100644 --- a/src/wp-admin/includes/ms.php +++ b/src/wp-admin/includes/ms.php @@ -905,6 +905,8 @@ function confirm_delete_users( $users ) { ) ); } + + // TODO: Check if user has content. ?> From 3cc768e03e419014aa4633288614e6de8d124dfc Mon Sep 17 00:00:00 2001 From: Dominik Schilling Date: Tue, 15 Jul 2025 11:13:51 +0200 Subject: [PATCH 06/20] Exclude user to delete from reassignment dropdown --- src/wp-admin/includes/ms.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/wp-admin/includes/ms.php b/src/wp-admin/includes/ms.php index baf90c7cb6a47..2f30f7497d7b3 100644 --- a/src/wp-admin/includes/ms.php +++ b/src/wp-admin/includes/ms.php @@ -864,6 +864,7 @@ function confirm_delete_users( $users ) { if ( ! is_array( $users ) || empty( $users ) ) { return false; } + ?>

    @@ -932,6 +933,7 @@ function confirm_delete_users( $users ) { array( 'blog_id' => $details->userblog_id, 'fields' => array( 'ID', 'user_login' ), + 'exclude' => $users, ) ); From 29804371ed160e62574db6e00f03664d3f44eb91 Mon Sep 17 00:00:00 2001 From: Dominik Schilling Date: Tue, 15 Jul 2025 11:33:06 +0200 Subject: [PATCH 07/20] Add ID to submit button --- src/wp-admin/includes/ms.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wp-admin/includes/ms.php b/src/wp-admin/includes/ms.php index 2f30f7497d7b3..ccad916d6ed95 100644 --- a/src/wp-admin/includes/ms.php +++ b/src/wp-admin/includes/ms.php @@ -999,7 +999,7 @@ function confirm_delete_users( $users ) { 'confirm-users-deletion' ) ); ?> Date: Tue, 15 Jul 2025 11:33:23 +0200 Subject: [PATCH 08/20] Add TODO --- src/wp-admin/includes/ms.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/wp-admin/includes/ms.php b/src/wp-admin/includes/ms.php index ccad916d6ed95..45f95b0080aad 100644 --- a/src/wp-admin/includes/ms.php +++ b/src/wp-admin/includes/ms.php @@ -966,6 +966,7 @@ function confirm_delete_users( $users ) { printf( __( 'Site: %s' ), $user_site ); ?>
  • +