Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Coding Standards for PasswordHash class #185

Open
wants to merge 2 commits into
base: master
from

Conversation

@bhubbard
Copy link

bhubbard commented Mar 8, 2020

Lots of small improvements to improve PHP Coding Standards for class-phpass.php

Trac ticket: https://core.trac.wordpress.org/ticket/49596


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Lots of small improvements to improve PHP Coding Standards for `class-phpass.php`

https://core.trac.wordpress.org/ticket/49596
* @param integer $iteration_count_log2 Iteration Count Log2.
* @param boolean $portable_hashes Portable Hashes.
*/
public function __construct( int $iteration_count_log2, bool $portable_hashes ) {

This comment has been minimized.

Copy link
@todeveni

todeveni Mar 8, 2020

WordPress has a minimum version requirement of PHP 5.6, so bool and int type hints in functions can't be used, since they're PHP 7+ only.

This comment has been minimized.

Copy link
@bhubbard

bhubbard Mar 9, 2020

Author

Ok, all type hints should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.