Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add muted for [video] #54788 #2137

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Benouare
Copy link

I add the support of the muted attribute in the video tag to be able to use the autoplay.
Currently, the mute wasnt available, so the autoplay looks useless.

More info on : https://core.trac.wordpress.org/ticket/54788


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

Hi @Benouare! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@Benouare Benouare force-pushed the feature/fix_media_muted_#54788 branch 2 times, most recently from ca9cfd7 to 140d154 Compare January 11, 2022 09:05
@Benouare Benouare force-pushed the feature/fix_media_muted_#54788 branch from 140d154 to c744b41 Compare January 11, 2022 17:33
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the docblock for wp_video_shortcode() are you able to add the following below * @since 3.6.0

 * @since 6.0.0 Add support for the muted attribute.

I'm unable to add a suggestion, sorry, as the line is outside the pull request's diff. Apart from that, the code looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants