Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve file type extension check in check_upload_mimes() to fix loose check #293

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Nikschavan
Copy link

Trac ticket: https://core.trac.wordpress.org/ticket/50136


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@ayazwpseo

This comment was marked as spam.

Copy link

github-actions bot commented Feb 23, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props nikschavan, ayeshrajans, ayazahmed12, judyeland.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@judyeland
Copy link

judyeland commented Feb 23, 2024

What about if we add jpg format as well here its code

'foo', // Added 'jpg' to the list of allowed file extensions 'tx' => 'bar', 't' => 'baz', ]; $allowed_mimes = check_upload_mimes( $mimes ); $this->assertTrue( isset( $allowed_mimes['srt|txt|png|jpg'] ) ); $this->assertTrue( isset( $allowed_mimes['t'] ) ); $this->assertFalse( isset( $allowed_mimes['tx'] ) ); $this->assertFalse( isset( $allowed_mimes['rt'] ) ); $this->assertFalse( isset( $allowed_mimes['xf'] ) ); } } endif;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants