Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing the new Requires Network plugin header #3717

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

petitphp
Copy link

@petitphp petitphp commented Dec 2, 2022

Implementation of the new Requires Network plugin header.

Changes from this PR only touch parts of the admin UI that relies on data from get_plugin_data.
Other parts of the admin that use the response from the WP.org plugin API were not updated.

Trac ticket: https://core.trac.wordpress.org/ticket/57220


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @petitphp. Left some review comments.

src/wp-admin/includes/class-plugin-installer-skin.php Outdated Show resolved Hide resolved
src/wp-admin/includes/class-plugin-upgrader.php Outdated Show resolved Hide resolved
src/wp-admin/includes/class-wp-plugins-list-table.php Outdated Show resolved Hide resolved
src/wp-admin/includes/class-wp-plugins-list-table.php Outdated Show resolved Hide resolved
}

/**
* Data provider.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Data provider.
* Data provider for test_is_php_version_compatible().

petitphp and others added 6 commits December 7, 2022 16:40
…staller-skin.php

Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
…grader.php

Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
…s-list-table.php

Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants