56886: Allow Network admin to determine whether a new site should be indexed by search engines or not #3882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indexed by search engines or not.
kabir-coderex
suggested changes
Mar 20, 2025
| <?php endif; // Languages. ?> | ||
| <tr class="form-field"> | ||
| <th scope="row"> | ||
| <label> |
There was a problem hiding this comment.
Can we use for attribute in the label tag? It’s better for accessibility as it links the label to the corresponding input. Like,
<label for="site-privacy-public-on">
| <fieldset> | ||
| <legend class="screen-reader-text"><?php esc_html_e( 'Site Privacy' ); ?></legend> | ||
| <label for="site-privacy-public-on"> | ||
| <input name="blog[meta][blog_public]" type="radio" id="site-privacy-public-on" value="1"<?php checked( true ); ?> /> <?php echo esc_html_x( 'Yes', 'Multisite new site public privacy on' ); ?> |
There was a problem hiding this comment.
Can we use dynamic check for default selection? Like:
checked( get_option( 'blog_public' ), 1 );
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://core.trac.wordpress.org/ticket/56886