Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport new endpoint for Pattern Directory categories #3905

Conversation

ntsekouras
Copy link

Trac ticket: https://core.trac.wordpress.org/ticket/57551

Addition of the new endpoint for Pattern Directory categories.
Related GB PR: WordPress/gutenberg#45749


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@ntsekouras
Copy link
Author

Since I'm not sure if the Patterns Directory integration will be merged in time for 6.2, let's wait a bit for this PR.

Even though I think this endpoint wouldn't hurt to land in core, it isn't actually used anywhere yet, so it might be better to land when the integration lands. --cc @hellofromtonya

@ntsekouras ntsekouras marked this pull request as draft January 26, 2023 06:36
@hellofromtonya
Copy link
Contributor

As this is part of a larger initiative, if that initiative might not land in 6.2, then yes I agree this PR should not go in yet. Why? Its purpose is for the Pattern Directory Explorer. Committing it now without the explorer being committed means the endpoint isn't used in Core and there's a potential for BC concerns should the endpoint need to change as the explorer continues in development and testing.

@ntsekouras
Copy link
Author

The connection with Pattern Directory will not be ready for 6.2, so I'm closing this PR.

@ntsekouras ntsekouras closed this Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants