Don't update translations asynchronously during tests

[ocean90]

The tests for WP_REST_Plugins_Controller::create_item() in WP_REST_Plugins_Controller_Test are doing real api.w.org requests which will also return data about outdated translations. If the tests are run again, Language_Pack_Upgrader::sync_upgrade() will now update the translations based on the previous data.

Trac ticket: https://core.trac.wordpress.org/ticket/51670

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[desrosj]

This looks good to me, and I also think I know what caused this to start happening all of a sudden.

In the commit in question, I also expanded the list of excluded files when packaging the ZIP file during the setup job to include .git*, and packagehash.txt. If packagehash.txt was present on the actual test jobs, it would prevent the npx install-changed command from running the install command. I added the .git* exclusion to prevent the .git folder from also being included.

The code right before apply_filters( 'async_update_translation' ) runs the is_vcs_checkout() check and returns early if the site appears to be under version control. When the .git folder was excluded from the ZIP file, the follow up jobs in the workflow that run the tests would no longer assume that the install is under version control, and the language packs would be updated.

It's not clear to me whether running the tests with the assumption that the install is under version control is preferred, though. If it is, we should probably override the is_vcs_checkout() function with the automatic_updates_is_vcs_checkout filter in the test suite itself to always guarantee the site will be viewed as under VCS.

[TimothyBJacobs]

I thought it was blocked because that is only hooked in the admin? https://core.trac.wordpress.org/ticket/50732#comment:17

Ignore me, I'm an idiot.