Skip to content

Comments: Add missing dots in wp-includes/formatting.php #8241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Infinite-Null wants to merge 2 commits into from
Closed

Comments: Add missing dots in wp-includes/formatting.php #8241

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c675e53
Comments: Add missing dots
Infinite-Null Feb 3, 2025
a140a59
Revert period from emoji arrays marker comment
Infinite-Null Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/wp-includes/formatting.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ function wpautop( $text, $br = true ) {
// Replace newlines that shouldn't be touched with a placeholder.
$text = preg_replace_callback( '/<(script|style|svg|math).*?<\/\\1>/s', '_autop_newline_preservation_helper', $text );

// Normalize <br>
// Normalize <br>.
$text = str_replace( array( '<br>', '<br/>' ), '<br />', $text );

// Replace any new line characters that aren't preceded by a <br /> with a <br />.
Expand Down Expand Up @@ -621,7 +621,7 @@ function wp_html_split( $input ) {
*
* @since 4.4.0
*
* @return string The regular expression
* @return string The regular expression.
*/
function get_html_split_regex() {
static $regex;
Expand Down Expand Up @@ -681,7 +681,7 @@ function get_html_split_regex() {
* @since 4.4.0
*
* @param string $shortcode_regex Optional. The result from _get_wptexturize_shortcode_regex().
* @return string The regular expression
* @return string The regular expression.
*/
function _get_wptexturize_split_regex( $shortcode_regex = '' ) {
static $html_regex;
Expand Down Expand Up @@ -723,7 +723,7 @@ function _get_wptexturize_split_regex( $shortcode_regex = '' ) {
* @since 4.4.0
*
* @param string[] $tagnames Array of shortcodes to find.
* @return string The regular expression
* @return string The regular expression.
*/
function _get_wptexturize_shortcode_regex( $tagnames ) {
$tagregexp = implode( '|', array_map( 'preg_quote', $tagnames ) );
Expand Down Expand Up @@ -877,7 +877,7 @@ function shortcode_unautop( $text ) {
* @author bmorel at ssi dot fr (modified)
* @since 1.2.1
*
* @param string $str The string to be checked
* @param string $str The string to be checked.
* @return bool True if $str fits a UTF-8 model, false otherwise.
*/
function seems_utf8( $str ) {
Expand All @@ -904,7 +904,7 @@ function seems_utf8( $str ) {
return false; // Does not match any model.
}

for ( $j = 0; $j < $n; $j++ ) { // n bytes matching 10bbbbbb follow ?
for ( $j = 0; $j < $n; $j++ ) { // n bytes matching 10bbbbbb follow?
if ( ( ++$i === $length ) || ( ( ord( $str[ $i ] ) & 0xC0 ) !== 0x80 ) ) {
return false;
}
Expand Down Expand Up @@ -1139,7 +1139,7 @@ function wp_check_invalid_utf8( $text, $strip = false ) {
* @since 5.8.3 Added the `encode_ascii_characters` parameter.
*
* @param string $utf8_string String to encode.
* @param int $length Max length of the string
* @param int $length Max length of the string.
* @param bool $encode_ascii_characters Whether to encode ascii characters such as < " '
* @return string String with Unicode encoded for URI.
*/
Expand Down Expand Up @@ -2536,9 +2536,9 @@ function convert_invalid_entities( $content ) {
*
* @since 0.71
*
* @param string $text Text to be balanced
* @param string $text Text to be balanced.
* @param bool $force If true, forces balancing, ignoring the value of the option. Default false.
* @return string Balanced text
* @return string Balanced text.
*/
function balanceTags( $text, $force = false ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
if ( $force || (int) get_option( 'use_balanceTags' ) === 1 ) {
Expand Down Expand Up @@ -4696,7 +4696,7 @@ function esc_attr( $text ) {
*
* @since 2.0.6
*
* @param string $safe_text The text after it has been escaped.
* @param string $safe_text The text after it has been sanitized and escaped.
Copy link
Contributor

@peterwilsoncc peterwilsoncc Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esc_attr() is an escaping function, as WordPress uses the term sanitization for user input this could be confusing to developers.

Suggested change
* @param string $safe_text The text after it has been sanitized and escaped.
* @param string $safe_text The text after it has been escaped.

Copy link
Author

@Infinite-Null Infinite-Null Feb 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @peterwilsoncc,
Should I open a follow-up PR to address this issue?

Copy link
Contributor

@peterwilsoncc peterwilsoncc Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Infinite-Null Don't worry, it was more a nit pick than a particular concern.

Sorry about the coincidence of timing as I commented and Sergey committed. These things happen occasionally :)

Copy link
Author

@Infinite-Null Infinite-Null Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries at all! I appreciate the clarification. Thank You 😄

* @param string $text The text prior to being escaped.
*/
return apply_filters( 'attribute_escape', $safe_text, $text );
Expand Down
Loading