Skip to content

Conversation

@jjlazo79
Copy link

@jjlazo79 jjlazo79 commented Jun 3, 2025

Trac ticket: https://core.trac.wordpress.org/ticket/63521#ticket

WP version: 6.8
PHP version: 8.2
Environment: Official Docker image with WP_UnitTest

Adding a unit test environment using WP_UnitTests, Buggregator throws several
Deprecated: Creation of dynamic property WP_Term::$category_description is deprecated warnings.

The issue points to the _make_cat_compat function because it tries to assign values ​​to object properties that are not defined in WP_Term.

I suggest defining the old properties on WP_Terms

Deprecated: Creation of dynamic property WP_Term::$cat_name is deprecated in /var/www/html/wp-content/themes/themename/tests/wordpress-develop/src/wp-includes/category.php on line 381

Deprecated: Creation of dynamic property WP_Term::$category_nicename is deprecated in /var/www/html/wp-content/themes/themename/tests/wordpress-develop/src/wp-includes/category.php on line 382

Deprecated: Creation of dynamic property WP_Term::$category_parent is deprecated in /var/www/html/wp-content/themes/themename/tests/wordpress-develop/src/wp-includes/category.php on line 383
 ✔ Exclude ab test from query method

Deprecated: Creation of dynamic property WP_Term::$cat_ID is deprecated in /var/www/html/wp-content/themes/themename/tests/wordpress-develop/src/wp-includes/category.php on line 378

Deprecated: Creation of dynamic property WP_Term::$category_count is deprecated in /var/www/html/wp-content/themes/themename/tests/wordpress-develop/src/wp-includes/category.php on line 379

Deprecated: Creation of dynamic property WP_Term::$category_description is deprecated in /var/www/html/wp-content/themes/themename/tests/wordpress-develop/src/wp-includes/category.php on line 380

Deprecated: Creation of dynamic property WP_Term::$cat_name is deprecated in /var/www/html/wp-content/themes/themename/tests/wordpress-develop/src/wp-includes/category.php on line 381

After the fix:

AB_Test_Post_ (ThemeName\Tests\Theme\Growth\AB_Test_Post_)
 ✔ Alter post query method
 ✔ Add ab test post meta
 ✔ Maybe add no index meta tag method
 ✔ Render ab test settings meta box method
 ✔ Exclude ab test from query method
 ✔ Save ab test settings
 ✔ Add canonical url

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

Hi @jjlazo79! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jose-lazo.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant