Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix register_activation_hook callback $network_wide parameter #961

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

noplanman
Copy link

When using register_activation_hook, the "activate_{$plugin}" action doesn't pass the $network_wide boolean as the parameter for the callback.

Instead, the parameter gets substituted with an empty string, breaking the page when using strict typing, as it expects a boolean.

Looking at how it's done when activating plugins, it uses is_network_admin() as the parameter

activate_plugins( $plugins, self_admin_url( 'plugins.php?error=true' ), is_network_admin() );

Same thing should happen here:

do_action( "activate_{$plugin}" );

do_action( "activate_{$plugin}", is_network_admin() );

Trac ticket: https://core.trac.wordpress.org/ticket/52405#ticket


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

Hi @noplanman! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant