Fix register_activation_hook
callback $network_wide
parameter
#961
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
register_activation_hook
, the"activate_{$plugin}"
action doesn't pass the$network_wide
boolean as the parameter for the callback.Instead, the parameter gets substituted with an empty string, breaking the page when using strict typing, as it expects a boolean.
Looking at how it's done when activating plugins, it uses
is_network_admin()
as the parameterwordpress-develop/src/wp-admin/plugins.php
Line 124 in 6ef5edd
Same thing should happen here:
wordpress-develop/src/wp-admin/plugins.php
Line 193 in 6ef5edd
do_action( "activate_{$plugin}", is_network_admin() );
Trac ticket: https://core.trac.wordpress.org/ticket/52405#ticket
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.