Skip to content

Conversation

@desrosj
Copy link
Member

@desrosj desrosj commented Sep 16, 2025

It looks like r60612 and r60624 will need to be backported to older branches.

When working on a ticket that backported changes to older branches, I noticed that the Check Built Files workflow was failing for the 6.8 branch with the following error:

Invalid workflow file: .github/workflows/check-built-files.yml#L42
The workflow is not valid. .github/workflows/check-built-files.yml (Line: 42, Col: 3): Error calling workflow 'WordPress/wordpress-develop/.github/workflows/reusable-check-built-files.yml@trunk'. The nested job 'update-built-files' is requesting 'contents: read', but is only allowed 'contents: none'.

The same was true with the upgrade develop testing workflow:

Invalid workflow file: .github/workflows/upgrade-develop-testing.yml#L54
The workflow is not valid. .github/workflows/upgrade-develop-testing.yml (Line: 54, Col: 3): Error calling workflow 'WordPress/wordpress-develop/.github/workflows/reusable-upgrade-testing.yml@trunk'. The nested job 'upgrade-tests' is requesting 'contents: read', but is only allowed 'contents: none'.

All of the others seem to be working as expected. These two workflows were introduced during the 6.8 cycle, so thankfully this does not need to be backported further. @johnbillion I'm going to add this to the list we have started for a GitHub Actions page in the handbook.

Trac ticket: Core-63170


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@desrosj desrosj self-assigned this Sep 16, 2025
desrosj and others added 3 commits September 15, 2025 21:03
This workflow should only ever run in `trunk`.
…workflows.

These permissions are not required for a public repo but are required for a private repo, for example a private fork.

Props johnbillion, desrosj

See #63170

git-svn-id: https://develop.svn.wordpress.org/trunk@60612 602fd350-edb4-49c9-b593-d223f7449a82
…Actions workflows.

These permissions are not required for a public repo but are required for a private repo, for example a private fork.

Props johnbillion, desrosj

Follow-up to r60612.

See #63170

git-svn-id: https://develop.svn.wordpress.org/trunk@60624 602fd350-edb4-49c9-b593-d223f7449a82
@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@desrosj desrosj requested a review from johnbillion September 16, 2025 01:28
@desrosj desrosj marked this pull request as ready for review September 16, 2025 01:28
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props desrosj, johnbillion.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
Copy link
Member Author

desrosj commented Sep 17, 2025

Merged in r60773.

@desrosj desrosj closed this Sep 17, 2025
@desrosj desrosj deleted the test/workflow-permissions branch September 17, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants