Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds development build instructions #81

Merged
merged 6 commits into from Oct 7, 2022

Conversation

erikyo
Copy link
Collaborator

@erikyo erikyo commented Jun 11, 2022

this PR will adds the basic build instructions in order to get the development environment working.

Copy link
Collaborator

@bacoords bacoords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with all of this. It makes a lot of sense to keep this in the main readme and continue updating it as the plugin evolves.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Joe Bailey-Roberts <33831317+Sephsekla@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
@erikyo erikyo requested a review from Sephsekla June 16, 2022 10:04
Copy link
Collaborator

@bacoords bacoords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@erikyo
Copy link
Collaborator Author

erikyo commented Jun 17, 2022

hey @Sephsekla, just came to my mind we can add something like
"postinstall": "npm run build"
to package.json in order to trigger automatically the build command after npm i was done, In this way the first build process could be even simpler! What do you think?

@bacoords
Copy link
Collaborator

@erikyo @Sephsekla Do we need additional work on this branch?

@erikyo
Copy link
Collaborator Author

erikyo commented Jul 19, 2022

@bacoords, I think it's completed, those are just the instructions to build the dev environment nothing more!

@erikyo erikyo merged commit 2dfc327 into WordPress:develop Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants