Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Rosetta header search for initial launch #58

Closed
iandunn opened this issue Jan 5, 2022 · 5 comments
Closed

Hide Rosetta header search for initial launch #58

iandunn opened this issue Jan 5, 2022 · 5 comments
Labels
[Type] Question Further information is requested
Milestone

Comments

@iandunn
Copy link
Member

iandunn commented Jan 5, 2022

The old Rosetta header doesn't have a search form, but the new global header does.

Some Rosetta subsites like /support, /themes, etc have their own search forms in the secondary header.

Should we disable the search in the primary header on Rosetta sites, to match the old header, or keep it? If we keep it, what content should be searched?

Search options:

  • global w.org network (including main English sites) - https://wordpress.org/search/do-search.php regardless of which subsite you're on
  • current rosetta site (e.g., when on /support, only /support would be searched)
  • main rosetta site (e.g., when on /support, only / would be searched. the secondary header form could be used to search /support
  • main and subsites (e.g., when on /support, it'd search /, /team/, support, etc)
@iandunn iandunn added the [Type] Question Further information is requested label Jan 5, 2022
@iandunn iandunn added this to the News launch milestone Jan 5, 2022
@dd32
Copy link
Member

dd32 commented Jan 7, 2022

Historically the Global Search has been excluded from rosetta sites, as one may expect it to search localised content, rather than the english content.

From a search perspective for non-English locales, a search that doesn't search their locale-specific data is pretty irrelevant.

I vote we hide it, until a better option comes forward for full site search.

@iandunn
Copy link
Member Author

iandunn commented Jan 10, 2022

So that's basically the "main and subsites" option above? That makes sense to me 👍🏻

The first idea that comes to mind is using Google to search {user query} site:{locale}.wordpress.org, similar to how the English search works.

@dd32
Copy link
Member

dd32 commented Jan 13, 2022

So that's basically the "main and subsites" option above?

My vote was to exclude the Search block from the header entirely for localised sites, which is the current rosetta header functionality.

The first idea that comes to mind is using Google to search {user query} site:{locale}.wordpress.org, similar to how the English search works.

If Google Custom Search worked in such a way that we could do this, now that w.org/search is a WP page, we could probably do just that - but AFAIK it would require us to create a specific search-engine instance for each locale.

I suggest:

  • We hide it for initial news launch for localised sites
  • Post launch we look at a custom GCS instance, or making the existing one domain-aware

@iandunn
Copy link
Member Author

iandunn commented Jan 13, 2022

👍🏻

@iandunn iandunn changed the title Should Rosetta sites have search in the header? Hide Rosetta header search for initial launch Jan 14, 2022
@ryelle
Copy link
Contributor

ryelle commented Jan 20, 2022

The search was hidden in #105, and #89 is for adding a real search, so I think this issue can be closed.

@ryelle ryelle closed this as completed Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants