Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of dropdown caret in the Local Navigation Bar block. #606

Merged
merged 6 commits into from
May 3, 2024

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented May 1, 2024

Fixes #604

The dropdown "caret" was misaligned in the Local Navigation Bar block on mobile. It should line up with the = icon in the global header.

Current Proposed
image image

And here's a video of the fix in action.

dropdown-caret.mp4

Copy link
Contributor

@ryelle ryelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about the double-nav implementation here, you didn't pick an easy task to jump in on 😅

Looking good on small screens:

Screenshot 2024-05-01 at 5 28 38 PM

Except for About — this has some padding set on that block so that pattern should be updated once this is merged.
Screenshot 2024-05-01 at 5 22 42 PM

The mid-and-larger sizes need some updates still, though, left a thread of comments.

mu-plugins/blocks/local-navigation-bar/postcss/style.pcss Outdated Show resolved Hide resolved
@ndiego
Copy link
Member Author

ndiego commented May 1, 2024

I forgot about the double-nav implementation here, you didn't pick an easy task to jump in on 😅

I knew it was too easy. I'll dig into this tomorrow. Thanks for reviewing.

@ndiego
Copy link
Member Author

ndiego commented May 2, 2024

@ryelle, thanks again for testing. I think I have solved the issues in the recent commit.

Copy link
Contributor

@ryelle ryelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! Thanks for keeping at it 🙂

@ryelle ryelle merged commit 73f8ad6 into trunk May 3, 2024
2 checks passed
@ryelle ryelle deleted the fix-local-nav-caret-alignment branch May 3, 2024 14:35
@ndiego
Copy link
Member Author

ndiego commented May 3, 2024

Looks good now! Thanks for keeping at it 🙂

😅 And thanks for all your help!

@StevenDufresne
Copy link
Contributor

It looks like this happened again?

https://meta.trac.wordpress.org/ticket/7656

@ryelle
Copy link
Contributor

ryelle commented May 29, 2024

Looks like we still need to do this step:

Except for About — this has some padding set on that block so that pattern should be updated once this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local Navigation: Fix dropdown caret alignment on mobile
3 participants