-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alignment of dropdown caret in the Local Navigation Bar block. #606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot about the double-nav implementation here, you didn't pick an easy task to jump in on 😅
Looking good on small screens:
Except for About — this has some padding set on that block so that pattern should be updated once this is merged.
The mid-and-larger sizes need some updates still, though, left a thread of comments.
I knew it was too easy. I'll dig into this tomorrow. Thanks for reviewing. |
@ryelle, thanks again for testing. I think I have solved the issues in the recent commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now! Thanks for keeping at it 🙂
😅 And thanks for all your help! |
It looks like this happened again? |
Looks like we still need to do this step:
|
Fixes #604
The dropdown "caret" was misaligned in the Local Navigation Bar block on mobile. It should line up with the = icon in the global header.
And here's a video of the fix in action.
dropdown-caret.mp4