Skip to content
This repository was archived by the owner on Apr 24, 2025. It is now read-only.

Conversation

@m-vdb
Copy link

@m-vdb m-vdb commented Sep 1, 2015

No description provided.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring? Complex method, worth summarizing the things it'll check.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment doesn't seem useful.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy paste :(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is worth a comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, at which point do we check that we have all contained_field requirements fulfilled?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also copy-paste :(

m-vdb pushed a commit that referenced this pull request Sep 1, 2015
@m-vdb m-vdb merged commit 547a9aa into master Sep 1, 2015
@m-vdb m-vdb deleted the mvdb/JKR-9392/fix-listifield branch September 1, 2015 23:40
olivierlefloch pushed a commit that referenced this pull request Mar 16, 2017
Fixing 'field assigned before declaration' error
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants