Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dart 2 - 2.x stable] Update analyzer version range #363

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

joebingham-wk
Copy link
Contributor

@joebingham-wk joebingham-wk commented Oct 9, 2019

Motivation

Upper bounds of the analyzer version need to be increased so that we aren't prevented from pulling newer versions of packages (e.g., build_web_compilers) that depend on newer versions of analyzer.

Changes

  • Update Analyzer dependency.

Release Notes

  • Increase the analyzer dependency upper bound to ensure the package can consume the latest version of other dependencies.

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:
@aaronlademann-wf @greglittlefield-wf @kealjones-wk @sydneyjodon-wk

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed
    • Steps from PR author:

      • Verify analyzer can resolve to 0.38.5 and there are no static errors.
        • Pull down branch.
        • Upgrade analyzer.
        • Verify it resolves to 0.38.5 and there are no static errors.
    • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@joebingham-wk joebingham-wk changed the base branch from master to master_stable+dart2 October 9, 2019 21:18
@kealjones-wk
Copy link
Contributor

+10

@kealjones-wk
Copy link
Contributor

@Workiva/release-management-p

@rmconsole7-wk rmconsole7-wk merged commit e72421d into master_stable+dart2 Oct 9, 2019
@rmconsole7-wk rmconsole7-wk deleted the CPLAT-7678-bump-analyzer-range branch October 9, 2019 23:57
@aaronlademann-wf aaronlademann-wf changed the title Update analyzer version range [Dart 2 - 2.x stable] Update analyzer version range Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants