CPLAT-8693 Finalize `connect` for w_flux #459

joebingham-wk · 2020-02-04T20:44:03Z

Motivation

To aid in the transition from w_flux to Redux, there should be tools and utilities that make it easier to transition.

Changes

Note: this branch also includes the changes introduced in #439. Consequently, if the changes are in web/ or doc/ and not specified here, they were introduced in #439.

over_react_flux.dart
redux_mutli_provider.dart
value_mutation_checker.dart
hoc.dart (in lib/src/util)
Tests related to those files (including connect_flux_integration_test.dart)
Added two sections in flux_to_redux.md.

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:
@greglittlefield-wf @aaronlademann-wf @sydneyjodon-wk

QA Checklist

Tests were updated and provide good coverage of the changeset and other affected code
Manual testing was performed if needed
- Steps from PR author:
  - QA the examples in web, paying attention to the react profile and the updates that occur (checking for any weird updating behavior)
  - No missing test coverage, and that CI passes
- Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

A Client Platform member has reviewed these changes
There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
For release PRs - Version metadata in Rosie comment is correct

greglittlefield-wf

One more pass, only have a couple more places to look. This is really close!!

doc/flux_to_redux.md

lib/src/util/hoc.dart

test/over_react/util/hoc_test.dart

lib/src/over_react_redux/over_react_flux.dart

test/over_react_redux/connect_flux_test.dart

greglittlefield-wf · 2020-02-19T21:36:52Z

test/over_react_redux/connect_flux_test.dart

+      });
+    });
+
+    group('properly handles parameter combinations for', () {


greglittlefield-wf · 2020-02-19T21:39:11Z

test/over_react_redux/connect_flux_test.dart

+      final fluxCounter = queryByTestId(jacket.mountNode, 'flux-component');
+      final fluxButton = queryByTestId(fluxCounter, 'button-increment');
+
+      final logs = await recordConsoleLogsAsync(() async {


Awww yeah, recordConsoleLogsAsync came in handy! 😄

Yeah it did! I might use it in the other ticket I'm working on now too.. it's super handy haha

test/over_react_redux/connect_flux_test.dart

Co-Authored-By: Greg Littlefield <greg.littlefield@workiva.com>

…8693-connect-for-w_flux

greglittlefield-wf

Last bit of feedback! Running a semver report as well to make sure the public API looks good

README.md

doc/flux_to_redux.md

web/flux_to_redux/advanced/examples/influx_implementation/store.dart

semveraudit-wf · 2020-02-24T17:41:11Z

Public API Changes

Recommendation: ⚠️ Minor version bump

+ over_react/over_react_flux.dart

// Adding an entry point is a minor change.

@@ line 289: package:over_react/src/over_react_redux/over_react_flux.dart @@
+  TProps Function([Map<dynamic, dynamic>]) Function(TProps Function([Map<dynamic, dynamic>])) connectFlux({Map Function(TStore state) mapStateToProps, Map Function(TStore state, TProps ownProps) mapStateToPropsWithOwnProps, Map Function(TActions actions) mapActionsToProps, Map Function(TActions actions, TProps ownProps) mapActionsToPropsWithOwnProps, Map Function(TProps stateProps, TProps dispatchProps, TProps ownProps) mergeProps, bool Function(TProps nextProps, TProps prevProps) areOwnPropsEqual, bool Function(TProps nextProps, TProps prevProps) areStatePropsEqual, bool Function(TProps nextProps, TProps prevProps) areMergedPropsEqual, Context context, bool pure = true, bool forwardRef = false});
// Adding a top-level function is a minor change.

@@ line 326: package:over_react/src/over_react_redux/over_react_redux.dart @@
+  UiFactory<ReduxProviderProps> ReduxProvider = ([map]) => ReduxProviderProps(map);
// Adding a top-level variable is a minor change.

@@ line 17: package:over_react/src/over_react_redux/redux_multi_provider.over_react.g.dart @@
+  ReactDartComponentFactoryProxy2<Component2> get $ReduxMultiProviderComponentFactory;
// Adding a top-level variable is a minor change.

@@ line 1: package:over_react/src/util/hoc.dart @@
+  R Function(A) composeHocs(Iterable<R Function(A)> functions);
// Adding a top-level function is a minor change.

Click to see 10 more API Changes

@@ line 35: package:over_react/src/over_react_redux/redux_multi_provider.dart @@
+  UiFactory<ReduxMultiProviderProps> ReduxMultiProvider = _$ReduxMultiProvider;
// Adding a top-level variable is a minor change.

@@ line 117: package:over_react/src/over_react_redux/over_react_flux.dart @@
+  class FluxToReduxAdapterStore<S extends InfluxStoreMixin<dynamic>> extends Store<State> {}
// Adding a class is a minor change.

+     FluxToReduxAdapterStore(this.store, dynamic actions, {List<redux.Middleware<S>> middleware});
//    Adding a constructor is a minor change.

+     Future<dynamic> teardown();
//    Adding a method is a minor change.

+     S get store;
//    Adding a field is a minor change.

      From package:redux/src/store.dart
+     S get state;
//    Adding a field is a minor change.
+     Reducer<S> reducer;
//    Adding a field is a minor change.
+     void dispatch(dynamic action);
//    Adding a method is a minor change.
+     Stream<S> get onChange;
//    Adding a field is a minor change.

@@ line 51: package:over_react/src/over_react_redux/redux_multi_provider.dart @@
+  class ReduxMultiProviderComponent extends UiComponent2<TProps extends UiProps> {}
// Adding a class is a minor change.

+     ReduxMultiProviderComponent();
//    Adding a constructor is a minor change.

+     dynamic render();
//    Adding a method is a minor change.

      From package:over_react/src/component_declaration/builder_helpers.dart
+     bool get $isClassGenerated;
//    Adding a field is a minor change.

      From package:over_react/src/component_declaration/component_base_2.dart
+     String getPropKey(void Function(TProps props) accessProp);
//    Adding a method is a minor change.
+     void validateRequiredProps(Map appliedProps);
//    Adding a method is a minor change.
+     void redraw([ Function() callback]);
//    Adding a method is a minor change.
+     ReduxMultiProviderProps typedPropsFactory(Map propsMap);
//    Adding a method is a minor change.
+     String keyForProp(void Function(TProps props) accessProp);
//    Adding a method is a minor change.
+     Map<dynamic, dynamic> copyProps({bool omitReservedReactProps = true, bool onlyCopyDomProps = false, Iterable keysToOmit, Iterable<Iterable> keySetsToOmit});
//    Adding a method is a minor change.
+     Map<String, Error Function(ReduxMultiProviderProps, PropValidatorInfo)> get propTypes;
//    Adding a field is a minor change.
+     ReduxMultiProviderProps newProps();
//    Adding a method is a minor change.
+     Map<dynamic, dynamic> unwrappedProps;
//    Adding a field is a minor change.
+     ReduxMultiProviderProps typedPropsFactoryJs(JsBackedMap propsMap);
//    Adding a method is a minor change.
+     Iterable<ConsumedProps> get $defaultConsumedProps;
//    Adding a field is a minor change.
+     ClassNameBuilder forwardingClassNameBuilder();
//    Adding a method is a minor change.
+     void addUnconsumedDomProps(Map props);
//    Adding a method is a minor change.
+     Map<dynamic, dynamic> copyUnconsumedProps();
//    Adding a method is a minor change.
+     Iterable<ConsumedProps> get consumedProps;
//    Adding a field is a minor change.
+     void addUnconsumedProps(Map props);
//    Adding a method is a minor change.
+     Map<dynamic, dynamic> copyUnconsumedDomProps();
//    Adding a method is a minor change.
+     Map<dynamic, dynamic> props;
//    Adding a field is a minor change.
+     void validateProps(Map appliedProps);
//    Adding a method is a minor change.
+     Context get contextType;
//    Adding a field is a minor change.

      From package:over_react/src/component_declaration/disposable_manager_proxy.dart
+     StreamSubscription<T> listenToStream(Stream<T> stream, void Function(T event) onData, {Function onError, void Function() onDone, bool cancelOnError});
//    Adding a method is a minor change.
+     void componentWillUnmount();
//    Adding a method is a minor change.
+     Future<T> getManagedDelayedFuture(Duration duration, T Function() callback);
//    Adding a method is a minor change.
+     T manageAndReturnTypedDisposable(T disposable);
//    Adding a method is a minor change.
+     void manageDisposable(Disposable disposable);
//    Adding a method is a minor change.
+     ManagedDisposer getManagedDisposer(Disposer disposer);
//    Adding a method is a minor change.
+     Completer<T> manageCompleter(Completer<T> completer);
//    Adding a method is a minor change.
+     Timer getManagedTimer(Duration duration, void Function() callback);
//    Adding a method is a minor change.
+     void manageDisposer(Disposer disposer);
//    Adding a method is a minor change.
+     Future<T> awaitBeforeDispose(Future<T> future);
//    Adding a method is a minor change.
+     Timer getManagedPeriodicTimer(Duration duration, void Function(Timer timer) callback);
//    Adding a method is a minor change.
+     void manageStreamController(StreamController controller);
//    Adding a method is a minor change.
+     Disposable manageAndReturnDisposable(Disposable disposable);
//    Adding a method is a minor change.
+     void manageStreamSubscription(StreamSubscription subscription);
//    Adding a method is a minor change.

      From package:react/react.dart
+     void setState(covariant dynamic newState, [callback()]);
//    Adding a method is a minor change.
+     void componentWillReceivePropsWithContext(Map newProps, dynamic nextContext);
//    Adding a method is a minor change.
+     void componentDidCatch(dynamic error, ReactErrorInfo info);
//    Adding a method is a minor change.
+     void replaceState(Map newState, [callback()]);
//    Adding a method is a minor change.
+     void forceUpdate([SetStateCallback callback]);
//    Adding a method is a minor change.
+     dynamic initComponentInternal(props, _jsRedraw, [RefMethod ref, _jsThis, context]);
//    Adding a method is a minor change.
+     Map<dynamic, dynamic> prevState;
//    Adding a field is a minor change.
+     void componentWillReceiveProps(Map newProps);
//    Adding a method is a minor change.
+     Map<dynamic, dynamic> getDerivedStateFromError(dynamic error);
//    Adding a method is a minor change.
+     Map<dynamic, dynamic> nextContext;
//    Adding a field is a minor change.
+     Map<dynamic, dynamic> nextProps;
//    Adding a field is a minor change.
+     Map<dynamic, dynamic> get nextState;
//    Adding a field is a minor change.
+     Map<dynamic, dynamic> getDerivedStateFromProps(Map nextProps, Map prevState);
//    Adding a method is a minor change.
+     String get displayName;
//    Adding a field is a minor change.
+     dynamic initStateInternal();
//    Adding a method is a minor change.
+     bool shouldComponentUpdate(Map nextProps, Map nextState);
//    Adding a method is a minor change.
+     Map<dynamic, dynamic> get defaultProps;
//    Adding a field is a minor change.
+     List<dynamic Function()> get setStateCallbacks;
//    Adding a field is a minor change.
+     void componentWillMount();
//    Adding a method is a minor change.
+     RefMethod ref;
//    Adding a field is a minor change.
+     Iterable<String> get contextKeys;
//    Adding a field is a minor change.
+     Map<dynamic, dynamic> getInitialState();
//    Adding a method is a minor change.
+     void setStateWithUpdater(StateUpdaterCallback updater, [SetStateCallback callback]);
//    Adding a method is a minor change.
+     Map<dynamic, dynamic> prevContext;
//    Adding a field is a minor change.
+     Map<dynamic, dynamic> getDefaultProps();
//    Adding a method is a minor change.
+     void transferComponentState();
//    Adding a method is a minor change.
+     void componentDidMount();
//    Adding a method is a minor change.
+     Map<dynamic, dynamic> state;
//    Adding a field is a minor change.
+     Map<dynamic, dynamic> get initialState;
//    Adding a field is a minor change.
+     void componentWillUpdateWithContext(Map nextProps, Map nextState, dynamic nextContext);
//    Adding a method is a minor change.
+     bool shouldComponentUpdateWithContext(Map nextProps, Map nextState, dynamic nextContext);
//    Adding a method is a minor change.
+     dynamic getSnapshotBeforeUpdate(Map prevProps, Map prevState);
//    Adding a method is a minor change.
+     ReactComponent jsThis;
//    Adding a field is a minor change.
+     Iterable<String> get childContextKeys;
//    Adding a field is a minor change.
+     List<Map<dynamic, dynamic> Function(Map<dynamic, dynamic>, Map<dynamic, dynamic>)> get transactionalSetStateCallbacks;
//    Adding a field is a minor change.
+     Map<String, dynamic> getChildContext();
//    Adding a method is a minor change.
+     void componentDidUpdate(Map prevProps, Map prevState, [dynamic snapshot]);
//    Adding a method is a minor change.
+     void componentWillUpdate(Map nextProps, Map nextState);
//    Adding a method is a minor change.

@@ line 77: package:over_react/src/over_react_redux/redux_multi_provider.over_react.g.dart @@
+  class ReduxMultiProviderProps {}
// Adding a class is a minor change.

+     ReduxMultiProviderProps();
//    Adding a constructor is a minor change.

+     Map<dynamic, dynamic> get props;
//    Adding a field is a minor change.

+     Map<Context<dynamic>, Store<dynamic>> storesByContext;
//    Adding a field is a minor change.

+     static PropsMeta get meta;
//    Adding a field is a minor change.

      From package:over_react/src/component/prop_mixins.over_react.g.dart
+     MouseEventCallback onDragEnter;
//    Adding a field is a minor change.
+     AnimationEventCallback onAnimationEnd;
//    Adding a field is a minor change.
+     ClipboardEventCallback onCopy;
//    Adding a field is a minor change.
+     Map<String, dynamic> style;
//    Adding a field is a minor change.
+     PointerEventCallback onPointerCancel;
//    Adding a field is a minor change.
+     PointerEventCallback onPointerOut;
//    Adding a field is a minor change.
+     MouseEventCallback onContextMenu;
//    Adding a field is a minor change.
+     ClipboardEventCallback onPaste;
//    Adding a field is a minor change.
+     TransitionEventCallback onTransitionEnd;
//    Adding a field is a minor change.
+     MouseEventCallback onMouseUp;
//    Adding a field is a minor change.
+     PointerEventCallback onPointerOver;
//    Adding a field is a minor change.
+     AriaPropsMixin get aria;
//    Adding a field is a minor change.
+     String title;
//    Adding a field is a minor change.
+     String id;
//    Adding a field is a minor change.
+     MouseEventCallback onMouseOut;
//    Adding a field is a minor change.
+     dynamic ref;
//    Adding a field is a minor change.
+     TouchEventCallback onTouchStart;
//    Adding a field is a minor change.
+     MouseEventCallback onMouseDown;
//    Adding a field is a minor change.
+     MouseEventCallback onDoubleClick;
//    Adding a field is a minor change.
+     MouseEventCallback onDragLeave;
//    Adding a field is a minor change.
+     FocusEventCallback onFocus;
//    Adding a field is a minor change.
+     PointerEventCallback onPointerLeave;
//    Adding a field is a minor change.
+     MouseEventCallback onDragEnd;
//    Adding a field is a minor change.
+     MouseEventCallback onDragExit;
//    Adding a field is a minor change.
+     MouseEventCallback onMouseLeave;
//    Adding a field is a minor change.
+     MouseEventCallback onMouseMove;
//    Adding a field is a minor change.
+     WheelEventCallback onWheel;
//    Adding a field is a minor change.
+     FormEventCallback onInput;
//    Adding a field is a minor change.
+     ClipboardEventCallback onCut;
//    Adding a field is a minor change.
+     PointerEventCallback onPointerUp;
//    Adding a field is a minor change.
+     KeyboardEventCallback onKeyDown;
//    Adding a field is a minor change.
+     FormEventCallback onReset;
//    Adding a field is a minor change.
+     PointerEventCallback onPointerMove;
//    Adding a field is a minor change.
+     TouchEventCallback onTouchEnd;
//    Adding a field is a minor change.
+     TouchEventCallback onTouchCancel;
//    Adding a field is a minor change.
+     PointerEventCallback onPointerEnter;
//    Adding a field is a minor change.
+     DomPropsMixin get dom;
//    Adding a field is a minor change.
+     dynamic tabIndex;
//    Adding a field is a minor change.
+     MouseEventCallback onClick;
//    Adding a field is a minor change.
+     KeyboardEventCallback onKeyUp;
//    Adding a field is a minor change.
+     KeyboardEventCallback onKeyPress;
//    Adding a field is a minor change.
+     UIEventCallback onScroll;
//    Adding a field is a minor change.
+     FormEventCallback onChange;
//    Adding a field is a minor change.
+     FormEventCallback onSubmit;
//    Adding a field is a minor change.
+     TouchEventCallback onTouchMove;
//    Adding a field is a minor change.
+     MouseEventCallback onDrop;
//    Adding a field is a minor change.
+     String key;
//    Adding a field is a minor change.
+     List<dynamic> children;
//    Adding a field is a minor change.
+     PointerEventCallback onPointerDown;
//    Adding a field is a minor change.
+     AnimationEventCallback onAnimationIteration;
//    Adding a field is a minor change.
+     MouseEventCallback onMouseOver;
//    Adding a field is a minor change.
+     FocusEventCallback onBlur;
//    Adding a field is a minor change.
+     MouseEventCallback onDragStart;
//    Adding a field is a minor change.
+     MouseEventCallback onDrag;
//    Adding a field is a minor change.
+     MouseEventCallback onDragOver;
//    Adding a field is a minor change.
+     AnimationEventCallback onAnimationStart;
//    Adding a field is a minor change.
+     MouseEventCallback onMouseEnter;
//    Adding a field is a minor change.

      From package:over_react/src/component_declaration/builder_helpers.dart
+     bool get $isClassGenerated;
//    Adding a field is a minor change.
+     String get propKeyNamespace;
//    Adding a field is a minor change.

      From package:over_react/src/component_declaration/component_base.dart
+     dynamic remove(Object key);
//    Adding a method is a minor change.
+     Iterable<MapEntry<dynamic, dynamic>> get entries;
//    Adding a field is a minor change.
+     Map<K2, V2> map(MapEntry<K2, V2> Function(K key, V value) f);
//    Adding a method is a minor change.
+     String get testId;
//    Adding a field is a minor change.
+     void addProps(Map propMap, [bool shouldAdd = true]);
//    Adding a method is a minor change.
+     bool containsValue(Object value);
//    Adding a method is a minor change.
+     bool get isNotEmpty;
//    Adding a field is a minor change.
+     ReactElement build([dynamic children]);
//    Adding a method is a minor change.
+     dynamic putIfAbsent(K key, V Function() ifAbsent);
//    Adding a method is a minor change.
+     int get length;
//    Adding a field is a minor change.
+     void forEach(void Function(K key, V value) action);
//    Adding a method is a minor change.
+     void addAll(Map<K, V> other);
//    Adding a method is a minor change.
+     Map<RK, RV> cast();
//    Adding a method is a minor change.
+     void []=(K key, V value);
//    Adding a method is a minor change.
+     Iterable<dynamic> get keys;
//    Adding a field is a minor change.
+     String getTestId({String key = defaultTestIdKey});
//    Adding a method is a minor change.
+     Map<dynamic, dynamic> get componentDefaultProps;
//    Adding a field is a minor change.
+     void clear();
//    Adding a method is a minor change.
+     void removeWhere(bool Function(K key, V value) predicate);
//    Adding a method is a minor change.
+     void addEntries(Iterable<MapEntry<K, V>> newEntries);
//    Adding a method is a minor change.
+     Iterable<dynamic> get values;
//    Adding a field is a minor change.
+     ReactComponentFactoryProxy componentFactory;
//    Adding a field is a minor change.
+     void addTestId(String value, {String key = defaultTestIdKey});
//    Adding a method is a minor change.
+     bool get isEmpty;
//    Adding a field is a minor change.
+     dynamic update(K key, V Function(V value) update, {V Function() ifAbsent});
//    Adding a method is a minor change.
+     void updateAll(V Function(K key, V value) update);
//    Adding a method is a minor change.
+     void modifyProps(PropsModifier modifier, [bool shouldModify = true]);
//    Adding a method is a minor change.
+     bool containsKey(Object key);
//    Adding a method is a minor change.
+     void addProp(propKey, value, [bool shouldAdd = true]);
//    Adding a method is a minor change.
+     ReactElement call([c1 = notSpecified, c2 = notSpecified, c3 = notSpecified, c4 = notSpecified, c5 = notSpecified, c6 = notSpecified, c7 = notSpecified, c8 = notSpecified, c9 = notSpecified, c10 = notSpecified, c11 = notSpecified, c12 = notSpecified, c13 = notSpecified, c14 = notSpecified, c15 = notSpecified, c16 = notSpecified, c17 = notSpecified, c18 = notSpecified, c19 = notSpecified, c20 = notSpecified, c21 = notSpecified, c22 = notSpecified, c23 = notSpecified, c24 = notSpecified, c25 = notSpecified, c26 = notSpecified, c27 = notSpecified, c28 = notSpecified, c29 = notSpecified, c30 = notSpecified, c31 = notSpecified, c32 = notSpecified, c33 = notSpecified, c34 = notSpecified, c35 = notSpecified, c36 = notSpecified, c37 = notSpecified, c38 = notSpecified, c39 = notSpecified, c40 = notSpecified]);
//    Adding a method is a minor change.
+     dynamic [](Object key);
//    Adding a method is a minor change.

      From package:over_react/src/util/class_names.over_react.g.dart
+     String classNameBlacklist;
//    Adding a field is a minor change.
+     String className;
//    Adding a field is a minor change.

@@ line 16: package:over_react/src/over_react_redux/over_react_flux.over_react.g.dart @@
+  class ConnectFluxPropsMixin<TActions> {}
// Adding a class is a minor change.

+     static List<String> get $propKeys;
//    Adding a field is a minor change.

+     static List<PropDescriptor> get $props;
//    Adding a field is a minor change.

+     static PropsMeta get meta;
//    Adding a field is a minor change.

+     ConnectFluxPropsMixin();
//    Adding a constructor is a minor change.

      From package:over_react/src/component/prop_mixins.over_react.g.dart
+     AnimationEventCallback onAnimationStart;
//    Adding a field is a minor change.
+     ClipboardEventCallback onPaste;
//    Adding a field is a minor change.
+     PointerEventCallback onPointerLeave;
//    Adding a field is a minor change.
+     dynamic tabIndex;
//    Adding a field is a minor change.
+     MouseEventCallback onDragEnter;
//    Adding a field is a minor change.
+     PointerEventCallback onPointerMove;
//    Adding a field is a minor change.
+     MouseEventCallback onMouseOut;
//    Adding a field is a minor change.
+     MouseEventCallback onMouseMove;
//    Adding a field is a minor change.
+     PointerEventCallback onPointerOut;
//    Adding a field is a minor change.
+     Map<String, dynamic> style;
//    Adding a field is a minor change.
+     MouseEventCallback onDragEnd;
//    Adding a field is a minor change.
+     KeyboardEventCallback onKeyDown;
//    Adding a field is a minor change.
+     PointerEventCallback onPointerEnter;
//    Adding a field is a minor change.
+     List<dynamic> children;
//    Adding a field is a minor change.
+     MouseEventCallback onDragOver;
//    Adding a field is a minor change.
+     KeyboardEventCallback onKeyPress;
//    Adding a field is a minor change.
+     PointerEventCallback onPointerUp;
//    Adding a field is a minor change.
+     MouseEventCallback onMouseLeave;
//    Adding a field is a minor change.
+     MouseEventCallback onDragLeave;
//    Adding a field is a minor change.
+     TouchEventCallback onTouchEnd;
//    Adding a field is a minor change.
+     String title;
//    Adding a field is a minor change.
+     MouseEventCallback onDragExit;
//    Adding a field is a minor change.
+     MouseEventCallback onMouseDown;
//    Adding a field is a minor change.
+     UIEventCallback onScroll;
//    Adding a field is a minor change.
+     FormEventCallback onInput;
//    Adding a field is a minor change.
+     FocusEventCallback onFocus;
//    Adding a field is a minor change.
+     PointerEventCallback onPointerOver;
//    Adding a field is a minor change.
+     MouseEventCallback onClick;
//    Adding a field is a minor change.
+     DomPropsMixin get dom;
//    Adding a field is a minor change.
+     ClipboardEventCallback onCut;
//    Adding a field is a minor change.
+     MouseEventCallback onDrop;
//    Adding a field is a minor change.
+     FormEventCallback onSubmit;
//    Adding a field is a minor change.
+     FormEventCallback onReset;
//    Adding a field is a minor change.
+     MouseEventCallback onDrag;
//    Adding a field is a minor change.
+     String key;
//    Adding a field is a minor change.
+     MouseEventCallback onDoubleClick;
//    Adding a field is a minor change.
+     MouseEventCallback onDragStart;
//    Adding a field is a minor change.
+     AnimationEventCallback onAnimationEnd;
//    Adding a field is a minor change.
+     TransitionEventCallback onTransitionEnd;
//    Adding a field is a minor change.
+     String id;
//    Adding a field is a minor change.
+     AnimationEventCallback onAnimationIteration;
//    Adding a field is a minor change.
+     TouchEventCallback onTouchMove;
//    Adding a field is a minor change.
+     TouchEventCallback onTouchStart;
//    Adding a field is a minor change.
+     FormEventCallback onChange;
//    Adding a field is a minor change.
+     TouchEventCallback onTouchCancel;
//    Adding a field is a minor change.
+     MouseEventCallback onContextMenu;
//    Adding a field is a minor change.
+     PointerEventCallback onPointerDown;
//    Adding a field is a minor change.
+     KeyboardEventCallback onKeyUp;
//    Adding a field is a minor change.
+     AriaPropsMixin get aria;
//    Adding a field is a minor change.
+     ClipboardEventCallback onCopy;
//    Adding a field is a minor change.
+     MouseEventCallback onMouseEnter;
//    Adding a field is a minor change.
+     FocusEventCallback onBlur;
//    Adding a field is a minor change.
+     dynamic ref;
//    Adding a field is a minor change.
+     MouseEventCallback onMouseOver;
//    Adding a field is a minor change.
+     PointerEventCallback onPointerCancel;
//    Adding a field is a minor change.
+     WheelEventCallback onWheel;
//    Adding a field is a minor change.
+     MouseEventCallback onMouseUp;
//    Adding a field is a minor change.

      From package:over_react/src/component_declaration/builder_helpers.dart
+     bool get $isClassGenerated;
//    Adding a field is a minor change.
+     String get propKeyNamespace;
//    Adding a field is a minor change.

      From package:over_react/src/component_declaration/component_base.dart
+     bool containsKey(Object key);
//    Adding a method is a minor change.
+     void addProp(propKey, value, [bool shouldAdd = true]);
//    Adding a method is a minor change.
+     void updateAll(V Function(K key, V value) update);
//    Adding a method is a minor change.
+     void modifyProps(PropsModifier modifier, [bool shouldModify = true]);
//    Adding a method is a minor change.
+     String get testId;
//    Adding a field is a minor change.
+     dynamic update(K key, V Function(V value) update, {V Function() ifAbsent});
//    Adding a method is a minor change.
+     Iterable<dynamic> get keys;
//    Adding a field is a minor change.
+     ReactElement build([dynamic children]);
//    Adding a method is a minor change.
+     void addEntries(Iterable<MapEntry<K, V>> newEntries);
//    Adding a method is a minor change.
+     void addProps(Map propMap, [bool shouldAdd = true]);
//    Adding a method is a minor change.
+     dynamic putIfAbsent(K key, V Function() ifAbsent);
//    Adding a method is a minor change.
+     void addTestId(String value, {String key = defaultTestIdKey});
//    Adding a method is a minor change.
+     bool get isEmpty;
//    Adding a field is a minor change.
+     void forEach(void Function(K key, V value) action);
//    Adding a method is a minor change.
+     dynamic [](Object key);
//    Adding a method is a minor change.
+     void clear();
//    Adding a method is a minor change.
+     Iterable<MapEntry<dynamic, dynamic>> get entries;
//    Adding a field is a minor change.
+     dynamic remove(Object key);
//    Adding a method is a minor change.
+     Map<dynamic, dynamic> get componentDefaultProps;
//    Adding a field is a minor change.
+     void addAll(Map<K, V> other);
//    Adding a method is a minor change.
+     int get length;
//    Adding a field is a minor change.
+     bool containsValue(Object value);
//    Adding a method is a minor change.
+     Map<RK, RV> cast();
//    Adding a method is a minor change.
+     bool get isNotEmpty;
//    Adding a field is a minor change.
+     ReactElement call([c1 = notSpecified, c2 = notSpecified, c3 = notSpecified, c4 = notSpecified, c5 = notSpecified, c6 = notSpecified, c7 = notSpecified, c8 = notSpecified, c9 = notSpecified, c10 = notSpecified, c11 = notSpecified, c12 = notSpecified, c13 = notSpecified, c14 = notSpecified, c15 = notSpecified, c16 = notSpecified, c17 = notSpecified, c18 = notSpecified, c19 = notSpecified, c20 = notSpecified, c21 = notSpecified, c22 = notSpecified, c23 = notSpecified, c24 = notSpecified, c25 = notSpecified, c26 = notSpecified, c27 = notSpecified, c28 = notSpecified, c29 = notSpecified, c30 = notSpecified, c31 = notSpecified, c32 = notSpecified, c33 = notSpecified, c34 = notSpecified, c35 = notSpecified, c36 = notSpecified, c37 = notSpecified, c38 = notSpecified, c39 = notSpecified, c40 = notSpecified]);
//    Adding a method is a minor change.
+     Iterable<dynamic> get values;
//    Adding a field is a minor change.
+     String getTestId({String key = defaultTestIdKey});
//    Adding a method is a minor change.
+     ReactComponentFactoryProxy componentFactory;
//    Adding a field is a minor change.
+     void removeWhere(bool Function(K key, V value) predicate);
//    Adding a method is a minor change.
+     Map<K2, V2> map(MapEntry<K2, V2> Function(K key, V value) f);
//    Adding a method is a minor change.
+     void []=(K key, V value);
//    Adding a method is a minor change.

      From package:over_react/src/over_react_redux/over_react_flux.dart
+     TActions actions;
//    Adding a field is a minor change.
+     Map<dynamic, dynamic> get props;
//    Adding a field is a minor change.

      From package:over_react/src/util/class_names.over_react.g.dart
+     String classNameBlacklist;
//    Adding a field is a minor change.
+     String className;
//    Adding a field is a minor change.

@@ line 174: package:over_react/src/over_react_redux/over_react_flux.dart @@
+  class InfluxStoreMixin<S> {}
// Adding a class is a minor change.

+     void influxReducer(dynamic action);
//    Adding a method is a minor change.

+     Reducer<S> get reduxReducer;
//    Adding a field is a minor change.

+     S state;
//    Adding a field is a minor change.

+     InfluxStoreMixin();
//    Adding a constructor is a minor change.

      From dart:async/stream.dart
+     Future<Store> elementAt(int index);
//    Adding a method is a minor change.
+     Stream<E> asyncExpand(Stream<E> convert(T event));
//    Adding a method is a minor change.
+     Stream<Store> asBroadcastStream({void onListen(StreamSubscription<T> subscription), void onCancel(StreamSubscription<T> subscription)});
//    Adding a method is a minor change.
+     Future<Store> get single;
//    Adding a field is a minor change.
+     Stream<Store> skipWhile(bool test(T element));
//    Adding a method is a minor change.
+     Stream<Store> timeout(Duration timeLimit, {void onTimeout(EventSink<T> sink)});
//    Adding a method is a minor change.
+     Future<bool> any(bool test(T element));
//    Adding a method is a minor change.
+     Future<Store> lastWhere(bool test(T element), {T orElse()});
//    Adding a method is a minor change.
+     Future<bool> every(bool test(T element));
//    Adding a method is a minor change.
+     Stream<Store> where(bool test(T event));
//    Adding a method is a minor change.
+     Future<Store> singleWhere(bool test(T element), {T orElse()});
//    Adding a method is a minor change.
+     Future<dynamic> pipe(StreamConsumer<T> streamConsumer);
//    Adding a method is a minor change.
+     Future<Store> reduce(T combine(T previous, T element));
//    Adding a method is a minor change.
+     Future<Store> get last;
//    Adding a field is a minor change.
+     Stream<Store> take(int count);
//    Adding a method is a minor change.
+     Stream<S> expand(Iterable<S> convert(T element));
//    Adding a method is a minor change.
+     Future<Store> get first;
//    Adding a field is a minor change.
+     Future<List<Store>> toList();
//    Adding a method is a minor change.
+     Stream<Store> distinct([bool equals(T previous, T next)]);
//    Adding a method is a minor change.
+     Future<Set<Store>> toSet();
//    Adding a method is a minor change.
+     Stream<Store> handleError(Function onError, {bool test(error)});
//    Adding a method is a minor change.
+     Stream<Store> skip(int count);
//    Adding a method is a minor change.
+     Future<S> fold(S initialValue, S combine(S previous, T element));
//    Adding a method is a minor change.
+     Future<E> drain([E futureValue]);
//    Adding a method is a minor change.
+     Future<bool> contains(Object needle);
//    Adding a method is a minor change.
+     Future<String> join([String separator = ""]);
//    Adding a method is a minor change.
+     Future<bool> get isEmpty;
//    Adding a field is a minor change.
+     Stream<Store> takeWhile(bool test(T element));
//    Adding a method is a minor change.
+     Stream<E> asyncMap(FutureOr<E> convert(T event));
//    Adding a method is a minor change.
+     Future<int> get length;
//    Adding a field is a minor change.
+     Stream<R> cast();
//    Adding a method is a minor change.
+     Future<Store> firstWhere(bool test(T element), {T orElse()});
//    Adding a method is a minor change.
+     Future<dynamic> forEach(void action(T element));
//    Adding a method is a minor change.
+     Stream<S> map(S convert(T event));
//    Adding a method is a minor change.
+     Stream<S> transform(StreamTransformer<T, S> streamTransformer);
//    Adding a method is a minor change.

      From package:w_common/src/common/disposable.dart
+     void manageDisposer(Disposer disposer);
//    Adding a method is a minor change.
+     int get disposalTreeSize;
//    Adding a field is a minor change.
+     Future<Null> onWillDispose();
//    Adding a method is a minor change.
+     Disposable manageAndReturnDisposable(Disposable disposable);
//    Adding a method is a minor change.
+     bool get isDisposed;
//    Adding a field is a minor change.
+     Timer getManagedTimer(Duration duration, void callback());
//    Adding a method is a minor change.
+     void manageStreamController(StreamController<dynamic> controller);
//    Adding a method is a minor change.
+     void flagLeak([String description]);
//    Adding a method is a minor change.
+     void manageDisposable(Disposable disposable);
//    Adding a method is a minor change.
+     bool get isOrWillBeDisposed;
//    Adding a field is a minor change.
+     Future<T> awaitBeforeDispose(Future<T> future);
//    Adding a method is a minor change.
+     T manageAndReturnTypedDisposable(T disposable);
//    Adding a method is a minor change.
+     Future<Null> dispose();
//    Adding a method is a minor change.
+     bool get isDisposedOrDisposing;
//    Adding a field is a minor change.
+     Future<Null> get didDispose;
//    Adding a field is a minor change.
+     ManagedDisposer getManagedDisposer(Disposer disposer);
//    Adding a method is a minor change.
+     void manageStreamSubscription(StreamSubscription<dynamic> subscription);
//    Adding a method is a minor change.
+     Completer<T> manageCompleter(Completer<T> completer);
//    Adding a method is a minor change.
+     StreamSubscription<T> listenToStream(Stream<T> stream, void onData(T event), {Function onError, void onDone(), bool cancelOnError});
//    Adding a method is a minor change.
+     bool get isLeakFlagSet;
//    Adding a field is a minor change.
+     Future<T> getManagedDelayedFuture(Duration duration, T callback());
//    Adding a method is a minor change.
+     bool get isDisposing;
//    Adding a field is a minor change.
+     Timer getManagedPeriodicTimer(Duration duration, void callback(Timer timer));
//    Adding a method is a minor change.
+     Future<Null> onDispose();
//    Adding a method is a minor change.

      From package:w_flux/src/store.dart
+     StreamSubscription<Store> listen(StoreHandler onData, {Function onError, void onDone(), bool cancelOnError});
//    Adding a method is a minor change.
+     void trigger();
//    Adding a method is a minor change.
+     void manageActionSubscription(ActionSubscription subscription);
//    Adding a method is a minor change.
+     void triggerOnActionV2(Action<T> action, [FutureOr<dynamic> onAction(T payload)]);
//    Adding a method is a minor change.
+     String get disposableTypeName;
//    Adding a field is a minor change.
+     dynamic triggerOnAction(Action action, [void onAction(payload)]);
//    Adding a method is a minor change.
+     bool get isBroadcast;
//    Adding a field is a minor change.

@@ line 41: package:over_react/src/over_react_redux/over_react_flux.dart @@
+  class ConnectFluxAdapterStore<S extends Store> extends Store<State> {}
// Adding a class is a minor change.

+     S get store;
//    Adding a field is a minor change.

+     ConnectFluxAdapterStore(this.store, dynamic actions, {List<redux.Middleware<S>> middleware});
//    Adding a constructor is a minor change.

+     Future<dynamic> teardown();
//    Adding a method is a minor change.

      From package:redux/src/store.dart
+     Stream<S> get onChange;
//    Adding a field is a minor change.
+     S get state;
//    Adding a field is a minor change.
+     Reducer<S> reducer;
//    Adding a field is a minor change.
+     void dispatch(dynamic action);
//    Adding a method is a minor change.

Ignored changes - `@experimental` members:

@@ line 51: package:over_react/src/over_react_redux/redux_multi_provider.dart @@
class ReduxMultiProviderComponent extends UiComponent2<TProps extends UiProps> {}

      From package:react/react.dart
+     dynamic context;
//    Adding a field is a minor change.

Ignored changes - `@visibleForTesting` members:

@@ line 26: package:over_react/src/over_react_redux/over_react_flux.dart @@
+  Expando<dynamic> get actionsForStore;
// Adding a top-level variable is a minor change.

@@ line 174: package:over_react/src/over_react_redux/over_react_flux.dart @@
class InfluxStoreMixin<S> {}

      From package:w_flux/src/store.dart
+     Stream<Store> get stream;
//    Adding a field is a minor change.

Showing results for 98e2c8b

Powered by semver-audit-service. Please report any problems by filing an issue.
Reported by the dart semver audit client 2.0.3
Browse public API.

greglittlefield-wf

+10

It's happening!!! Awesome work on this, @joebingham-wk!!

joebingham-wk · 2020-02-24T21:27:45Z

joebingham-wk · 2020-02-24T22:06:55Z

+1

greglittlefield-wf · 2020-02-24T22:32:25Z

@Workiva/release-management-p

joebingham-wk · 2020-02-24T22:33:33Z

joebingham-wk · 2020-02-24T22:40:15Z

+1

aaronlademann-wf

+1

@Workiva/release-management-pp

rmconsole-wf

+1 from RM

greglittlefield-wf and others added 30 commits October 30, 2019 19:26

Connected flux spike

e10ce15

Add warnings when store datastructures are mutated

9b74317

Add mapActionsToProps

9affb11

Improve, generalize, and encapsulate store value mutation detection

1a18380

Improve hashing helper API

a4f3573

Merge remote-tracking branch 'origin/master' into hacky-connected-flux

3412330

Add over_react_flux entrypoint

75770bf

Update generated files

cc00b54

Add ReduxMultiProvider and composeHocs

dba15f9

Add simple examples

19e7849

Get the pure flux app working

75d79bb

Add advanced example

215bb0d

Add a readme

4410b98

Add more to the readme

81ba8a4

Clean up a lil

93244b4

Add more to the docs

41a2488

Format

44dfdbd

Format with over_react_format

e444b8e

Add v2

3b06bb7

Delete v1

8d8b6e4

Refactor components

e791416

Refactor a lil more

8a8d52d

Tweak wording

24b33e3

Try format again

bf152c5

Format

7cdaf1b

Remove unnecessary keys

e2b640e

Address CR feedback

36f4a16

Merge in changes

d04b7ae

Refactor with new Influx model

ba53d9d

Update phase 3

29b9234

Remove equality check

db39b2c

greglittlefield-wf requested changes Feb 19, 2020

View reviewed changes

joebingham-wk and others added 7 commits February 19, 2020 14:49

Fix failing test

0457822

Apply suggestions from code review

b469c31

Co-Authored-By: Greg Littlefield <greg.littlefield@workiva.com>

Address CR feedback

110f3fd

Add one more expect

82d85ee

Add doc comment

7cfe47f

Merge branch '3.3.0-wip' of github.com:Workiva/over_react into CPLAT-…

2875eb9

…8693-connect-for-w_flux

Merge branch '3.3.0-wip' of github.com:Workiva/over_react into CPLAT-…

98e2c8b

…8693-connect-for-w_flux

joebingham-wk mentioned this pull request Feb 21, 2020

CPLAT-9691 Improve HOC Errors #466

Closed

7 tasks

greglittlefield-wf reviewed Feb 24, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

doc/flux_to_redux.md Outdated Show resolved Hide resolved

web/flux_to_redux/advanced/examples/influx_implementation/store.dart Outdated Show resolved Hide resolved

semveraudit-wf added the semver: Minor label Feb 24, 2020

greglittlefield-wf changed the base branch from 3.3.0-wip to master February 24, 2020 20:43

Address PR feedback

0a9e005

greglittlefield-wf approved these changes Feb 24, 2020

View reviewed changes

rmconsole-wf added the RM Ready label Feb 24, 2020

aaronlademann-wf approved these changes Feb 24, 2020

View reviewed changes

rmconsole-wf added Merge Requirements Met and removed Merge Requirements Unmet labels Feb 24, 2020

rmconsole-wf approved these changes Feb 24, 2020

View reviewed changes

rmconsole5-wk merged commit 43db688 into master Feb 24, 2020

rmconsole5-wk deleted the CPLAT-8693-connect-for-w_flux branch February 24, 2020 23:38

rmconsole-readonly-wk mentioned this pull request Feb 24, 2020

RM-67996 RM-67995 Release over_react 3.4.0 #467

Merged

joebingham-wk mentioned this pull request Feb 25, 2020

CPLAT-9691 Improve HOC Errors #469

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CPLAT-8693 Finalize `connect` for w_flux #459

CPLAT-8693 Finalize `connect` for w_flux #459

joebingham-wk commented Feb 4, 2020 •

edited

Loading

greglittlefield-wf left a comment

greglittlefield-wf Feb 19, 2020

greglittlefield-wf Feb 19, 2020

joebingham-wk Feb 19, 2020

greglittlefield-wf left a comment

semveraudit-wf commented Feb 24, 2020

Ignored changes - `@experimental` members:

Ignored changes - `@visibleForTesting` members:

greglittlefield-wf left a comment

joebingham-wk commented Feb 24, 2020 •

edited

Loading

joebingham-wk commented Feb 24, 2020

greglittlefield-wf commented Feb 24, 2020

joebingham-wk commented Feb 24, 2020

joebingham-wk commented Feb 24, 2020

aaronlademann-wf left a comment

rmconsole-wf left a comment

CPLAT-8693 Finalize connect for w_flux #459

CPLAT-8693 Finalize connect for w_flux #459

Conversation

joebingham-wk commented Feb 4, 2020 • edited Loading

Motivation

Changes

Release Notes

Review

QA Checklist

Merge Checklist

greglittlefield-wf left a comment

Choose a reason for hiding this comment

greglittlefield-wf Feb 19, 2020

Choose a reason for hiding this comment

greglittlefield-wf Feb 19, 2020

Choose a reason for hiding this comment

joebingham-wk Feb 19, 2020

Choose a reason for hiding this comment

greglittlefield-wf left a comment

Choose a reason for hiding this comment

semveraudit-wf commented Feb 24, 2020

Public API Changes

Ignored changes - @experimental members:

Ignored changes - @visibleForTesting members:

greglittlefield-wf left a comment

Choose a reason for hiding this comment

joebingham-wk commented Feb 24, 2020 • edited Loading

joebingham-wk commented Feb 24, 2020

greglittlefield-wf commented Feb 24, 2020

joebingham-wk commented Feb 24, 2020

joebingham-wk commented Feb 24, 2020

aaronlademann-wf left a comment

Choose a reason for hiding this comment

rmconsole-wf left a comment

Choose a reason for hiding this comment

CPLAT-8693 Finalize `connect` for w_flux #459

CPLAT-8693 Finalize `connect` for w_flux #459

joebingham-wk commented Feb 4, 2020 •

edited

Loading

Ignored changes - `@experimental` members:

Ignored changes - `@visibleForTesting` members:

joebingham-wk commented Feb 24, 2020 •

edited

Loading