CPLAT-9715 Fix accidental jsification of Map/Function Dart props when using connect
#461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// without any conversion needed by JS Components, and props are are fed directly | ||
| /// into Dart code (e.g., those passed into mapStateToPropsWithOwnProps/areOwnPropsEqual) | ||
| /// without needing unwrapping/conversion. | ||
| final hocFactoryProxy = ReactDartComponentFactoryProxy2(hoc); |
There was a problem hiding this comment.
@aaronlademann-wf We might want to consider just doing this for forwardRef as well (conditionally if the provided factory is a Dart component), since I think this jsification issue might still exist in react-dart 5.4.0-wip.
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
rmconsole4-wk
changed the title
connectconnect
joebingham-wk
approved these changes
Feb 17, 2020
|
|
||
| test('without converting the props whatsoever', () { | ||
| // Test functions/Maps to ensure they're not allowInterop'd, | ||
| // test event handlers to ensure they're not oterwise converted |
There was a problem hiding this comment.
#nit typo
Suggested change
| // test event handlers to ensure they're not oterwise converted | |
| // test event handlers to ensure they're not otherwise converted |
|
QA +1, Verified through https://github.com/Workiva/graph_ui/pull/1058 that the properties correctly get passed through connect as Dart props and not the previous js props |
|
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Wrapping Dart components in
connectunexpectedly jsified props, causingMapprops to show up as JS Objects when read by the component.Changes
Release Notes
connectReview
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review: @aaronlademann-wf @joebingham-wk @sydneyjodon-wk
FYI: @matthewnitschke-wk @kealjones-wk
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: