Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rip out Ionic default app assets throughout #133

Closed
advayDev1 opened this issue Mar 21, 2020 · 6 comments
Closed

Rip out Ionic default app assets throughout #133

advayDev1 opened this issue Mar 21, 2020 · 6 comments
Assignees
Labels
Projects

Comments

@advayDev1
Copy link
Collaborator

@advayDev1 advayDev1 commented Mar 21, 2020

Icons, splash screens, etc.

@advayDev1 advayDev1 added the client label Mar 21, 2020
@advayDev1 advayDev1 added this to the v0.1 milestone Mar 21, 2020
@hspinks hspinks added this to To do in Engineering via automation Mar 22, 2020
@sstur

This comment has been minimized.

Copy link
Collaborator

@sstur sstur commented Mar 22, 2020

I can take this one. Do we have an icon for the app yet? to replace the default one. What about for the splash screen, should I just make a white image with the blue logo on it?

@RohanTalip

This comment has been minimized.

Copy link
Collaborator

@RohanTalip RohanTalip commented Mar 22, 2020

I'm assuming that favicon(s) will also be updated?

@SamMousa

This comment has been minimized.

Copy link
Member

@SamMousa SamMousa commented Mar 22, 2020

For now I propose we take the favicon from WHO's website.
That way we have something decent and can update it later.

@sstur

This comment has been minimized.

Copy link
Collaborator

@sstur sstur commented Mar 23, 2020

I'm assuming that favicon(s) will also be updated?

Yes, I did this in #189, including the favicon.

@RohanTalip

This comment has been minimized.

Copy link
Collaborator

@RohanTalip RohanTalip commented Mar 24, 2020

Should this issue be closed now? Or is there still something left to do?

@sstur

This comment has been minimized.

Copy link
Collaborator

@sstur sstur commented Mar 25, 2020

Not yet, because #189 got rolled back so we have #256 in the pipeline but not yet approved for landing.

@advayDev1 advayDev1 removed this from the v0.1 milestone Mar 25, 2020
@myiremark myiremark closed this Mar 26, 2020
Engineering automation moved this from To do to Done Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Engineering
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.