Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat eslint warnings as errors on build #168

Closed

Conversation

@epicfaace
Copy link
Collaborator

epicfaace commented Mar 22, 2020

By setting CI=true during ionic build, we can make sure that eslint warnings are treated as errors on build. This PR sets that setting and also fixes existing eslint errors (array-callback-return, @typescript-eslint/no-unused-vars).

@epicfaace epicfaace requested a review from advayDev1 Mar 22, 2020
@epicfaace

This comment has been minimized.

Copy link
Collaborator Author

epicfaace commented Mar 22, 2020

Actually, there's a problem here. It appears that react-scripts has its own eslint config, but gts has another eslint config. I'd assume we want to switch over to gts's eslint config -- but react-scripts doesn't let you override the eslint config that it uses.

Probably the best way forward is just not to merge this PR and ignore all the warnings from react-scripts that come when running the app. This is sub-optimal though, since developers will see warnings from react-scripts that aren't actually enforced during development. I'm closing this for now @advayDev1 , but let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.