Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated styling Duplicate of PR#160 #176

Merged
merged 4 commits into from Mar 22, 2020

Conversation

@pjayathissa
Copy link
Collaborator

pjayathissa commented Mar 22, 2020

Note that this is not to latest Figma UI. TODO

This just fixes the layout, random shadows, padding, and learn more to bottom

Screenshot 2020-03-23 at 00 21 39

pjayathissa added 4 commits Mar 22, 2020
const classes = options.cssClasses;
classes.mainRoot += ' f6';
classes.root = 'sq-root';
classes.title += '';

This comment has been minimized.

Copy link
@sstur

sstur Mar 22, 2020

Collaborator

Nit: Any reason for these empty string lines?

This comment has been minimized.

Copy link
@pjayathissa

pjayathissa Mar 22, 2020

Author Collaborator

Left this as an issue for now Styling the Triage Form #178

This is still a work in progress, I ran out of time

@pjayathissa pjayathissa requested review from sstur and SamMousa Mar 22, 2020
@sstur
sstur approved these changes Mar 22, 2020
Copy link
Collaborator

sstur left a comment

This looks solid to me 💯

@SamMousa SamMousa merged commit ddc44ad into WorldHealthOrganization:master Mar 22, 2020
5 checks passed
5 checks passed
test (ubuntu-latest)
Details
test (macos-latest)
Details
build-android-debug (ubuntu-latest)
Details
build-android-debug (macos-latest)
Details
build-ios-debug
Details
@pjayathissa pjayathissa deleted the pjayathissa:updated-styling branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.