Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Icons and Splash #256

Closed
wants to merge 7 commits into from
Closed

Conversation

@sstur
Copy link
Collaborator

sstur commented Mar 24, 2020

What does this PR accomplish?

This adds the icons and splash screen, replacing the default Ionic assets.

Note: this is a re-hash of #189, but it still doesn't contain the symlinks or the new artwork, so I'm marking as a draft until we get that done.

Did you add any dependencies?

No.

How did you test the change?

Opened in Xcode and Android Studio.

Screen Shot 2020-03-22 at 15 52 30

Screen Shot 2020-03-22 at 15 56 16

Screen Shot 2020-03-22 at 15 57 08

@kassim kassim mentioned this pull request Mar 25, 2020
@kassim

This comment has been minimized.

Copy link
Contributor

kassim commented Mar 25, 2020

the icon doesn't render correctly for Android

Screenshot_1585095769

I've fixed it here sstur#1

and also added the symlinks for the Android icons

kassim and others added 3 commits Mar 25, 2020
fix: Android icon rendering and symlinks
@sstur sstur marked this pull request as ready for review Mar 25, 2020
@sstur sstur requested review from hspinks and advayDev1 Mar 25, 2020
@advayDev1 advayDev1 added the blocked label Mar 25, 2020
@advayDev1

This comment has been minimized.

Copy link
Collaborator

advayDev1 commented Mar 26, 2020

Thanks for the PR! Per our discussion this morning, we are committed to Flutter for the client, so closing these out for now.

@advayDev1 advayDev1 closed this Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.