Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile handlebars templates in production to improve performance #110

Closed
Wotuu opened this issue Jan 24, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@Wotuu
Copy link
Owner

commented Jan 24, 2019

@Wotuu Wotuu added the enhancement label Jan 24, 2019

@Wotuu Wotuu self-assigned this Jan 24, 2019

Wotuu added a commit that referenced this issue Feb 12, 2019

#110 Handlebars are now compiling, had to add a JS translations libra…
…ry for it as well to work. Took some time but that works now.

handlebars is renamed to Handlebars. The precompiled templates are quite easy to use now; see enemy.js for a conversion. I knew that template took the longest time to load so I converted that one first.
@Wotuu

This comment has been minimized.

Copy link
Owner Author

commented Feb 13, 2019

This now also happens in dev mode. Please run ./compile.sh every time you edit something in the .handlebars files. A bit annoying yes, but there shouldn't be enough changes in those files to warrant automating the compilation on-change (if that's even possible).

@Wotuu Wotuu closed this Feb 13, 2019

Wotuu added a commit that referenced this issue Feb 13, 2019

#110 A couple of high-usage handlebars have been precompiled now, thi…
…s saves a LOT of JS loading time. The page is visibly faster now which is great.

Not all templates have been converted, there's a bunch of PHP in some templates which are hardly used. For now I don't think it's wise to convert those purely for the sake of converting, the performance gains from those will be minimal. A lot of other small non-PHP templates have been converted.

Wotuu added a commit that referenced this issue Feb 14, 2019

@Wotuu Wotuu referenced this issue Feb 20, 2019

Merged

Development #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.