Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Patrols and Paths to use new Polyline system #115

Closed
Wotuu opened this issue Feb 4, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@Wotuu
Copy link
Owner

commented Feb 4, 2019

Patrols and Paths are actually Polylines, all vertices are stored in a separate table which is not really necessary. This slows down the website (though not really noticeable at the moment) and the benefits it gives are not being used nor will they ever be used. The vertices should be stored as a JSON object along with the Polyline. A Patrol and Path should have a relation to a Polyline instead.

@Wotuu Wotuu added the maintenance label Feb 4, 2019

@Wotuu Wotuu added this to the Reduce technical debt milestone Feb 4, 2019

@Wotuu Wotuu self-assigned this Feb 14, 2019

@Wotuu Wotuu changed the title Convert Patrols and Routes to use new Polyline system Convert Patrols and Paths to use new Polyline system Feb 14, 2019

Wotuu added a commit that referenced this issue Feb 14, 2019

Wotuu added a commit that referenced this issue Feb 14, 2019

#115 Converted packs and patrols to use their own vertices_json. Thou…
…gh I only just realized that the ticket wasn't exactly for this. It was ment to use the Polyline class. I'll fix that all in a later commit.

Wotuu added a commit that referenced this issue Feb 15, 2019

Wotuu added a commit that referenced this issue Feb 15, 2019

#115 Polylines are no longer an object like a Path is, it's now a way…
… of describing a polyline. Brushlines/paths/patrols will have a linked polyline instead, this enables more uniform way of defining such objects, plus it gives the same options to each of those options such as color/weight and more to be added later.

Polylines -> Brushlines have been completed. Path and Patrols are still on the TODO list for conversion. Packs may be converted as well.

Wotuu added a commit that referenced this issue Feb 16, 2019

#115 Polylines are now converted to a base class for all things that …
…use polylines. The previous polylines are now called Brushlines. Patrols and paths will be converted as well soon.

Wotuu added a commit that referenced this issue Feb 16, 2019

@Wotuu Wotuu closed this Feb 17, 2019

Wotuu added a commit that referenced this issue Feb 20, 2019

Wotuu added a commit that referenced this issue Feb 20, 2019

#115 Re-exported all dungeon data. This now uses the 'new system' whi…
…ch should increase performance across the board and increase flexibility.

@Wotuu Wotuu referenced this issue Feb 20, 2019

Merged

Development #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.