Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce inline JS/move JS in blades to compiled js. #154

Open
Wotuu opened this issue Mar 8, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@Wotuu
Copy link
Owner

commented Mar 8, 2019

There's quite a bit of page specific data that is currently there because of PHP usage or because translations were needed. The last one is no longer an issue so there should be a bunch that should be moved to JS assets instead.

@Wotuu Wotuu added the maintenance label Mar 8, 2019

Wotuu added a commit that referenced this issue Mar 11, 2019

Wotuu added a commit that referenced this issue Mar 12, 2019

#154 Initial version of the system that's going to reduce the amount …
…of inline JS, speeding up the page load. Route edit is converted, now the rest of the pages.

Wotuu added a commit that referenced this issue Mar 13, 2019

Wotuu added a commit that referenced this issue Mar 13, 2019

#154 Converted edit and view sidebar. Added option to add options to …
…your inline code. This helps with constructor variables.

Wotuu added a commit that referenced this issue Mar 13, 2019

#154 Added visibility handlebars template. Removed the options unwrap…
…ping from the DungeonMap, wanted to do that for some time.

There's now an issue where the bottom bar is not loaded properly. No idea where it came from, will have to debug tomorrow.

Wotuu added a commit that referenced this issue Mar 14, 2019

Wotuu added a commit that referenced this issue Apr 5, 2019

#154 Converted the map comment popup to a compiled handlebars templat…
…e. Introducted a new function for getting handlebars default values.

The handlebars default value function is more in line with what I want it to do, translations is one part of it. I want it to set default values like if the user is an admin or not etc. as well.
@Wotuu

This comment has been minimized.

Copy link
Owner Author

commented Apr 5, 2019

While there's still work to be done on this ticket, I feel like all of the important work for which this ticket was created is already done. Now I'm just making myself feel better about the code but not actually helping the website any further. I will continue to put time in this over the course of the project but I will not actively hold back other development while working on this ticket. It just doesn't give the end user anything back for my limited time.

I will keep this ticket open and put it on the long term so it's out of view for now.

@Wotuu Wotuu added the long term label Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.