Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Affixes admin pages #185

Closed
Wotuu opened this issue Jun 17, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@Wotuu
Copy link
Owner

commented Jun 17, 2019

It's currently working, but kinda hacky. It's not really that manageable and it requires a code update for every new season.

  • A place to manage M+ seasons

    • Couple a seasonal affix
    • Start and end date
    • Couple affix groups to the season in-order?
  • Manage affix groups

    • Create new ones, deactivate old ones
    • Couple 3 affixes to a group
    • Assign it to a season?

Because of the manual labor required to add affixes, going through the effort of creating a page for managing affixes themselves is too much work for too little gain.

@Wotuu Wotuu added the enhancement label Jun 17, 2019

@Wotuu Wotuu self-assigned this Jun 17, 2019

Wotuu added a commit that referenced this issue Jun 17, 2019

#185 Opted not to add any admin pages.
Instead, I've reworked the back-end to use Seasons rather than something injected in the GameServerRegion.
There's a new Service around which you ask when you want anything to do with M+ Seasons. Then, you can use the Season to resolve specifics for the information gathered in the Service.
Fixed an issue where filtering the routes table was not working anymore.
@Wotuu

This comment has been minimized.

Copy link
Owner Author

commented Jun 17, 2019

Opted not to add any admin pages.

Instead, I've reworked the back-end to use Seasons rather than something injected in the GameServerRegion. There's a new Service around which you ask when you want anything to do with M+ Seasons. Then, you can use the Season to resolve specifics for the information gathered in the Service.
Fixed an issue where filtering the routes table was not working anymore.

Updating the seeders is now enough to fully make everything functional when a new season/affix arrives. This is probably a better approach and saves a lot of time for me.

@Wotuu Wotuu closed this Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.