New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework map edit/view page so the map is full-screen #40

Closed
Wotuu opened this Issue Oct 9, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@Wotuu
Copy link
Owner

Wotuu commented Oct 9, 2018

For quick reference:

Maybe increase buttons size of main tools a little bit so they are more easier to spot. Or at least give some kind of color for main features (path and kill zones). Hotkeys for those features would be nice as well. I think left click for path, and right click for adding kill zone could work. Move map with middle mouse. It would give some smoothness for using this website. Now I feel like I end up searching correct tool.

Also definitely make map to be size of actual screen! Nothing is more horrible than have two moving components (map move, page scroll) in the same page. Makes things really messy! Now that I scroll things just go kinda ape sh*t because it can both zoom map and scroll page.
The delete button is a bit clunky to change over to. I'd prefer a right click option, which seems to already have the plumbing in place.

I think the right click option is a good idea. I'll have to think about it some more if this is a good addition moving forward. It may get a bit too easy to delete things. But then again it's quite easy to replace that which you just accidentally deleted.

Scrolling is perhaps another issue of its own, but the hotkeys + increase button size should be easily done.

@Wotuu Wotuu added the enhancement label Oct 9, 2018

@BlackFayah

This comment has been minimized.

Copy link

BlackFayah commented Oct 9, 2018

Maybe add a modifier, to separate page scroll from map zoom? Like CTRL+scroll for the map, regular scroll for the page?

@Wotuu

This comment has been minimized.

Copy link
Owner Author

Wotuu commented Oct 10, 2018

Funny that you mention that, I had that exact system in place but people thought it was too annoying so I got rid of it while I still had my life! 😛

I think the best solution for now would be to rewrite the view/edit pages to be full screen. But that's going to be a bit of work so it's not in the cards soon. But definitely not too far in the future.

@Wotuu Wotuu changed the title UX improvements Rework map edit/view page so the map is full-screen Oct 29, 2018

@Wotuu Wotuu self-assigned this Oct 29, 2018

Wotuu added a commit that referenced this issue Oct 29, 2018

#40 Initial setup for a full-screen map on the edit page. Rough, will…
… need cleaning up and refactoring but it works for now.

Wotuu added a commit that referenced this issue Oct 31, 2018

#40 Added a sidebar. Split up the CSS in the map to a separate file. …
…The sidebar works, just needs some more styling. Not sure about the white, probably needs a softer color but the dark color was too dark. I'll have to experiment a bit more.

Wotuu added a commit that referenced this issue Oct 31, 2018

#40 Sidebar is now functional for desktop and is styled properly. Wil…
…l now fill the sidebar with controls to edit the map with.

Wotuu added a commit that referenced this issue Oct 31, 2018

#40 Toolbox is now ready, Looking for some feedback now for more chan…
…ges. Need to implement some headers, and copy to clipboard functionality but mostly done. Still need to do admin and tryout page etc.

Wotuu added a commit that referenced this issue Oct 31, 2018

Wotuu added a commit that referenced this issue Nov 1, 2018

#40 Beginning integration of sidebar + fullscreen map in /try functio…
…nality. Getting there, not quite done yet.

Wotuu added a commit that referenced this issue Nov 1, 2018

#40 Reworked try to be a modal popup rather than a full page (unless …
…you go to /try manually). Moved some elements from /try into the sidebar, removed warning/global messages when in custom layout mode.

Wotuu added a commit that referenced this issue Nov 2, 2018

#40 Did a lot of updates to the sidebar and the new layout in both ed…
…it, view and try mode! I removed all UI elements and put them into the sidebar as much as possible. I also removed the top header for maximum visibility.

It's now very very close to final, just a few touch ups needed still but 98% there!

Wotuu added a commit that referenced this issue Nov 4, 2018

#40 Fixed a multitude of things related to splitting up the edit and …
…the view sidebars.

Virtual tour works again with the new layout.
Created some new global functions.
Every time you change the enemy forces, a small popup comes and notifies you of it.
Fixed an issue where Infested Voting information was not available on the tryout version. Voting is still not possible if you're not logged in.
Fixed an issue where you could attempt to assign raid markers to enemies in view mode (didn't work, but still). I also think I re-introduced this bug so hopefully it stays gone for a while now.

Wotuu added a commit that referenced this issue Nov 5, 2018

#40 Invisible raid markers are now completely hidden to prevent mouse…
… over events from triggering on them. Enemy forces popup no longer shows up when killing enemies with 0 enemy forces.

@Wotuu Wotuu referenced this issue Nov 5, 2018

Merged

Development #81

@Wotuu Wotuu closed this Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment