New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce sorting by more columns in the routes overview #65

Closed
Wotuu opened this Issue Oct 18, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@Wotuu
Copy link
Owner

Wotuu commented Oct 18, 2018

This was removed because it was non-functional. It's a problem because the Datatables library does not play nice with nested relationships and then possibly sorting by them. Two options:

a) Fix the Datatables library and get rid of the custom code that's currently doing the actual work. I replied to/opened an issue in the Datatables repository and that contained a link which may be of use for this.
b) Get rid of Datatables and go full custom (and thus also possibly revert the custom change to Tracker to make that one work)

Labelled as a bug as this was broken but just got removed to not mislead people. Still a bug.

@Wotuu Wotuu added the bug label Oct 18, 2018

@Wotuu Wotuu added this to the Improve routes page milestone Nov 9, 2018

Wotuu added a commit that referenced this issue Nov 19, 2018

#65 Started rework of the routes page, starting by leveraging functio…
…nalities of Yajra Datatables, though I'm starting to seriously doubt it's possible at all without just doing it custom.

Wotuu added a commit that referenced this issue Nov 20, 2018

#65 Getting rid of Yajra Datatables, it cannot do what I want. So I'm…
… making a custom solution. This is the initial work of it.

Wotuu added a commit that referenced this issue Nov 21, 2018

#65 Added proper filtering for affixes, and put routes which are for …
…the current affix week on the top of the list. asc/desc switching doesn't work yet though, still need to work on the order by query but the start is there.

Wotuu added a commit that referenced this issue Nov 21, 2018

Wotuu added a commit that referenced this issue Nov 23, 2018

#65 Added some code for a simple weighted rating sorting function. It…
…'s not perfect but I think it's good enough for now.

@Wotuu Wotuu closed this in 1f6b06d Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment