Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate map startup requests #85

Closed
Wotuu opened this issue Nov 9, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@Wotuu
Copy link
Owner

commented Nov 9, 2018

Currently all enemies, packs, comments, killzones etc. are all loaded separately from each other. This works, but it unnecessarily causes the page to load slower than could be the case. Ideally, there should be one endpoint called mapdata or something, which fetches all of these things at once and returns them.

Server-side this is not much of a problem, client-side this will require some rewrites to the way MapObjectGroups receive their data. They currently fetch their own data, this should probably be handled by the map instead, which then delegates the returned data to the MapObjectGroups instead. But that's still open for interpretation.

@Wotuu Wotuu added the enhancement label Nov 9, 2018

@Wotuu Wotuu added this to the Map backend improvements milestone Nov 9, 2018

@Wotuu Wotuu modified the milestones: Map backend improvements, 2.1: Various smaller improvements Jan 21, 2019

@Wotuu Wotuu added maintenance and removed enhancement labels Feb 4, 2019

Wotuu added a commit that referenced this issue Feb 18, 2019

#85 Rewritten the JS that is responsible for MapObjectGroups. The 'co…
…mbining' logic for them no longer lives in DungeonMap, but in a new class instead.

This keeps DungeonMap a bit cleaner, only sends out one AJAX request instead of 7-8, which should help speed up page loads by reducing round trips and server hits.

Wotuu added a commit that referenced this issue Feb 18, 2019

#85 Started rewriting the server side for listing things. Now there's…
… endpoints for all different areas, this makes the start to consolidating them all into one. About halfway with the rewrite.

@Wotuu Wotuu self-assigned this Feb 18, 2019

Wotuu added a commit that referenced this issue Feb 18, 2019

#85 Map startup requests are consolidated. They now feed off of one r…
…equest and are distributed accordingly. This speeds up the load of the site by reducing roundtrips.

Wotuu added a commit that referenced this issue Feb 18, 2019

Wotuu added a commit that referenced this issue Feb 18, 2019

#85 Fixed map:mapobjectgroupsfetchsuccess not firing.
I opted to fix it like this rather than fix everything else listening to this.map.manager.register('fetchsuccess'), not as clean tbh.

@Wotuu Wotuu closed this Feb 19, 2019

Wotuu added a commit that referenced this issue Feb 19, 2019

Wotuu added a commit that referenced this issue Feb 20, 2019

#85 Fixed path drawing display icon. Fixed error when switching floor…
…s. Added missing white space to enemy forces displaying.

@Wotuu Wotuu referenced this issue Feb 20, 2019

Merged

Development #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.