Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: rename Route to Path(, DungeonRoute to Route?) #88

Closed
Wotuu opened this issue Nov 9, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@Wotuu
Copy link
Owner

commented Nov 9, 2018

Terminology is getting a bit confusing internally. Outward facing, a DungeonRoute is a Route, it should just be called that internally as well. An internal Route is also called a Route, it should just be a Path (or similar), it's less confusing.

@Wotuu Wotuu added the enhancement label Nov 9, 2018

@Wotuu Wotuu added this to the Map backend improvements milestone Nov 9, 2018

@Wotuu Wotuu removed this from the Map backend improvements milestone Jan 21, 2019

@Wotuu Wotuu added this to the Reduce technical debt milestone Feb 4, 2019

@Wotuu Wotuu added maintenance and removed enhancement labels Feb 4, 2019

@Wotuu Wotuu self-assigned this Feb 8, 2019

@Wotuu

This comment has been minimized.

Copy link
Owner Author

commented Feb 8, 2019

I think Route to Path should do. DungeonRoute renaming would encompass a lot of things which is not really necessary just yet.

@Wotuu Wotuu closed this Feb 10, 2019

Wotuu added a commit that referenced this issue Feb 14, 2019

#88 Fixed some more references to ->routes to ->paths, should have th…
…em all now..

#133 Deleting a route now properly disposes of its thumbnails

@Wotuu Wotuu referenced this issue Feb 20, 2019

Merged

Development #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.