Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stompClientWillDisconnect missing #44

Closed
Erhannis opened this issue May 31, 2019 · 6 comments
Closed

stompClientWillDisconnect missing #44

Erhannis opened this issue May 31, 2019 · 6 comments

Comments

@Erhannis
Copy link
Contributor

@Erhannis Erhannis commented May 31, 2019

stompClientWillDisconnect was removed in 2017, but it is still listed in the documentation, and in fact is the suggested place to unsubscribe from a topic: Suggestion : Subscribe to your topic in "stompClientDidConnect" function and unsubcribe to your topic in stompClientWillDisconnect method. Either the method should be re-added, or the documentation should be updated.

@Erhannis

This comment has been minimized.

Copy link
Contributor Author

@Erhannis Erhannis commented May 31, 2019

Similarly with the entry for didReceiveMessageWithJSONBody ( Message Received via STOMP as String ), given as func stompClientJSONBody, which was removed in 2018.

@WrathChaos

This comment has been minimized.

Copy link
Owner

@WrathChaos WrathChaos commented Jun 3, 2019

Thank you so much @Erhannis,
I will research this issue and will remove these functions :)

@WrathChaos

This comment has been minimized.

Copy link
Owner

@WrathChaos WrathChaos commented Jun 14, 2019

Hello, again @Erhannis
I've updated the README for stompClientWillDisconnect. It is removed on README. However, can you provide me with a link and a replacement for didReceiveMessageWithJSONBody

I need a replacement for JSON handler.
Thank you, waiting for a response from you :)

@WrathChaos

This comment has been minimized.

Copy link
Owner

@WrathChaos WrathChaos commented Jun 14, 2019

New release is available

Release: 1.3.1

@Erhannis

This comment has been minimized.

Copy link
Contributor Author

@Erhannis Erhannis commented Jun 27, 2019

Thanks for the changes. I'm not sure I understand your second comment, though - my point was that in commit 28ef9738c0e96012c3fe5512b2d17a8455826ff4, last October, you removed the function stompClientJSONBody, and the README should therefore have the corresponding section removed (titled didReceiveMessageWithJSONBody ( Message Received via STOMP as String )). The remaining method gives the message as an object (as opposed to string). However, it WOULD be good to have a way of receiving the messages' text as it was received - not all stomp messages are JSON, after all, and sometimes users (me) want to be able to use the messages' text verbatim. I've added a parameter to the didReceiveMessageWithJSONBody method: akaStringBody stringBody: String? which just passes along body. I've created a pull request; #49 .

@WrathChaos

This comment has been minimized.

Copy link
Owner

@WrathChaos WrathChaos commented Jun 30, 2019

@Erhannis thank you so much :) I accepted your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.