Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Maven GPG Plugin for Signing / Fix GPG Sig Deployment #3

Merged
merged 1 commit into from Feb 16, 2019

Conversation

@Kortanul
Copy link
Member

Kortanul commented Feb 14, 2019

  • Eliminates manual invocation of the GPG command. If users need a locally-signed copy of build artifacts, they will need to manually sign them.
  • Switches from deploy:deploy-file to gpg:sign-and-deploy-file so that Maven takes care of signing EVERY artifact and UPLOADING the signatures to JFrog for us.
  • Switches from using the D7F749B5 signing key to using C081F89B since we have made modifications to this project so we are producing our own artifacts instead of just signing existing artifacts.
- Eliminates manual invocation of the GPG command. If users need a locally-signed copy of build artifacts, they will need to manually sign them.
- Switches from `deploy:deploy-file` to `gpg:sign-and-deploy-file` so that Maven takes care of signing EVERY artifact and UPLOADING the signatures to JFrog for us.
- Switches from using the `D7F749B5` signing key to using `C081F89B` since we have made modifications to this project so we are producing our own artifacts instead of just signing existing artifacts.
@pavelhoral pavelhoral self-requested a review Feb 15, 2019
Copy link
Member

pavelhoral left a comment

Looks good.

@Kortanul Kortanul merged commit 1f1d234 into sustaining/1.1.x Feb 16, 2019
1 check passed
1 check passed
semaphoreci The build passed on Semaphore.
Details
@Kortanul Kortanul deleted the feature/fix-gpg-signing branch Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.