[#41] Fail Gracefully when Debug Provider Invalid #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kortanul
force-pushed
the
feature/13.5.x/issue-41--debug-provider-fallback
branch
from
fd3e0fc
to
2078afa
Compare
Kortanul
changed the title
- Ensure that debug provider fallback is in place BEFORE trying to log any exceptions about failing to initialize the debug provider. - Upgrade `openam-shared` to JDK 8+ (see below). - Clean-up debug provider initialization. - Switch to multi-catch instead of repetitive `catch` blocks (JDK 7+). - Pull-in `forgerock-guava-base` to allow us to use `Strings.isNullOrEmpty()`. - Switch to `Optional` to support chaining `trim()` on provider names without an explicit `null` check (JDK 8+). Closes WrenSecurity#41.
Kortanul
force-pushed
the
feature/13.5.x/issue-41--debug-provider-fallback
branch
from
2078afa
to
842160c
Compare
siepkes
reviewed
Mar 2, 2019
| try { | ||
| provider = (IDebugProvider) Class.forName(providerName).newInstance(); | ||
| } catch (ClassNotFoundException cnex) { | ||
| provider = (IDebugProvider)Class.forName(providerName).newInstance(); |
There was a problem hiding this comment.
I realize that this code was already here but isn't newInstance considered evil? The docs say:
Note that this method propagates any exception thrown by the nullary constructor, including a checked exception. Use of this method effectively bypasses the compile-time exception checking that would otherwise be performed by the compiler. The Constructor.newInstance method avoids this problem by wrapping any exception thrown by the constructor in a (checked) InvocationTargetException.
| provider = (IDebugProvider) Class.forName(providerName).newInstance(); | ||
| } catch (ClassNotFoundException cnex) { | ||
| provider = (IDebugProvider)Class.forName(providerName).newInstance(); | ||
| } catch (ClassNotFoundException |
There was a problem hiding this comment.
Is there a point in catching specific exceptions? Doesn't any exception mean the provider failed to load? How would we deal with newer Java version throwing other exceptions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openam-sharedto JDK 8+ (see below).catchblocks (JDK 7+).forgerock-guava-baseto allow us to useStrings.isNullOrEmpty().Optionalto support chainingtrim()on provider names without an explicitnullcheck (JDK 8+).Closes #41.