Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to download on Windows 10 #2

Open
d-floe opened this issue Oct 20, 2017 · 17 comments
Labels

Comments

@d-floe
Copy link

@d-floe d-floe commented Oct 20, 2017

I was able to get this installed perfectly fine on my Windows 7 64x Desktop computer but for some reason trying to install this on my Windows 10 Pro 64x Laptop doesn't seem to do anything. Ive tried to run it as administrator and restarting my computer but nothing seems to work at all. Ive also cleared all my system thumbnail files and still nothing. I even tried the 32 bit version. Not quite sure what's going on, your demo was in Windows 10 so I'm a little confused as to why this isn't working.

@Wunkolo

This comment has been minimized.

Copy link
Owner

@Wunkolo Wunkolo commented Oct 20, 2017

Hm that's strange.
Try starting from a clean slate:
Run "uninstall.bat" and run Disk Cleanup on your thumbnails so that you're back to square one.

After that, hold down shift and right click at the same time in the folder where SaiThumbs.dll is in and you should see:
image
or it might say Open command window here.
Try entering the command regsvr32 SaiThumbs.dll and it should show a diagnostic message on if it installed properly or not:
image
It's possible that you might need to be running the installer as administrator as well:
image

@Wunkolo Wunkolo added the bug label Oct 20, 2017
@d-floe

This comment has been minimized.

Copy link
Author

@d-floe d-floe commented Oct 21, 2017

I tried your suggestion and this is what I got.
image
Running as administrator seems to do nothing either.
I even redownloaded the ZIP but it doesnt seem to change anything.

@Wunkolo

This comment has been minimized.

Copy link
Owner

@Wunkolo Wunkolo commented Oct 21, 2017

This seems to be an error that happens when you try to install a dll of a different architecture than your system(ex: registering a 32-bit DLL on a 64-bit Windows or 64-bit DLL on a 32-bit Windows).
Are you sure you have the correct version for your architecture downloaded?

@d-floe

This comment has been minimized.

Copy link
Author

@d-floe d-floe commented Oct 21, 2017

Well I tried this on the 32 bit version and I got this
image
It was great news but to my surprise, it didn't work. My thumbnails are still broken.

@Wunkolo

This comment has been minimized.

Copy link
Owner

@Wunkolo Wunkolo commented Oct 21, 2017

This is really weird as you shouldn't even be able to install the 32-bit version on a 64-bit machine at all without putting it through SysWoW64 but the 64-bit version that is native to your system refuses to install. Are you certain your machine is 64-bit? Try downloading the latest version on itch.io that I just recently updated and starting from a clean slate before installing.
When SaiThumbs is fully uninstalled then you should find that the registry entry for:
HKEY_CURRENT_USER\Software\Classes\.sai and HKEY_CURRENT_USER\Software\Classes\CLSID\{35788B9B-04AB-4B75-AB3A-1ED403AFC746} is completely gone.

You can check if the values exist or not by opening windows powershell and entering the commands:

Get-ItemProperty 'HKCU:\Software\Classes\.sai'
and
Get-ItemProperty 'HKCU:\Software\Classes\CLSID\{35788B9B-04AB-4B75-AB3A-1ED403AFC746}'

If both commands return an error after you run uninstall.bat then they both do not exist and you have a fresh slate to re-install.

If either exist then you currently have an installation that is possibly overriding each of your further attempts to reinstall.

@Sakuyamon

This comment has been minimized.

Copy link

@Sakuyamon Sakuyamon commented Oct 21, 2017

I got a win10 x64 computer and get the same errors... I tried both versions of the install and gone through everything said here but the error remain the same...

@d-floe

This comment has been minimized.

Copy link
Author

@d-floe d-floe commented Oct 21, 2017

Looks like the issue resolved itself?
After revisiting my laptop the next day it seems my thumbnails are working now after my previous post. Thanks for the help Wunkolo!!

@Wunkolo

This comment has been minimized.

Copy link
Owner

@Wunkolo Wunkolo commented Oct 23, 2017

@Sakuyamon are you still facing this issue?

@actualpedro

This comment has been minimized.

Copy link

@actualpedro actualpedro commented Oct 24, 2017

I have the same issue, running win10 x64, with the x64 version. Tried uninstalling and it still gives me the same error message, as well as running it with PowerShell or with admin privileges. Also tried adding the full file paths to the batch files, no change.

Also checked the registry just in case - no HKEY_CURRENT_USER\Software\Classes\.sai and HKEY_CURRENT_USER\Software\Classes\CLSID\{35788B9B-04AB-4B75-AB3A-1ED403AFC746} entries.

@ghost

This comment has been minimized.

Copy link

@ghost ghost commented Nov 2, 2017

aha... I see the problem. it's a 'current directory' issue.

https://www.codeproject.com/Tips/119828/Running-a-bat-file-as-administrator-Correcting-cur

Just add these two lines to the top of both your batch scripts:

@setlocal enableextensions
@cd /d "%~dp0"
@Wunkolo

This comment has been minimized.

Copy link
Owner

@Wunkolo Wunkolo commented Nov 3, 2017

@Sakuyamon @actualpedro have any of you tried these edits? You should be able to right-click the install.bat file and click edit to add these two lines. If it works I'll be sure to add it to the repo!

@Sakuyamon

This comment has been minimized.

Copy link

@Sakuyamon Sakuyamon commented Nov 3, 2017

I tried it... But it don't seem to work... It only stopped me from getting error messages when I installed it as an admin. No changes to my thumbnails...

@actualpedro

This comment has been minimized.

Copy link

@actualpedro actualpedro commented Nov 5, 2017

Sorry for the late reply! Tried it both with and without admin permissions, still results in the same error.

@Wunkolo Wunkolo added the help wanted label Feb 2, 2018
@Pikachewy

This comment has been minimized.

Copy link

@Pikachewy Pikachewy commented Mar 28, 2018

Hello,
I've been having the exact same issue when trying to install to a freshly installed copy of Windows 10, spent ages tinkering with the registry but I think I've found a potential fix. All I did was install Microsoft Office, then install SaiThumbs normally and now it works like a charm! Hopefully this can help others facing the same problem.

@Gameplayer9198

This comment has been minimized.

Copy link

@Gameplayer9198 Gameplayer9198 commented May 31, 2018

Found this extension today as my windows 10 install was still fresh, and error "The module "SaiThumbs.dll" Failed to load...." so here i am on this issue page.

So.. I found the issue from Pikachewys advice and deducted Runtimes, tested and i was correct.

@Gameplayer9198

This comment has been minimized.

Copy link

@Gameplayer9198 Gameplayer9198 commented May 31, 2018

@Wunkolo Yep Works without VCredist now. Glad to help😊

Wunkolo added a commit that referenced this issue May 31, 2018
Replaces all instances of `/MD` with `/MT`.
Should fix issue #2
@Wunkolo

This comment has been minimized.

Copy link
Owner

@Wunkolo Wunkolo commented May 31, 2018

Thank you for that. I pushed a commit that should statically link the runtimes so that the redist should not be needed to make installation easier.
@Pikachewy @actualpedro @Sakuyamon
Lemme know if the latest version works for you! I updated the itch.io page with the updated version and we might be able to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.