Make PreMotionEvent and PostMotionEvent work with vehicles (fixes #475)

[pcm1k]

This should fix issue #475.

[InfinitePower563]

Fixes a small bug effectively.

[sudofox]

Out of curiosity (and unfamiliarity with Fabric API) how does this fix work?

[pcm1k]

Out of curiosity (and unfamiliarity with Fabric API) how does this fix work?

For reference, the relevant code looks something like:

super.tick();
if (this.hasVehicle()) {
	this.networkHandler.sendPacket(new PlayerMoveC2SPacket.LookAndOnGround(this.getYaw(), this.getPitch(), this.onGround));
	this.networkHandler.sendPacket(new PlayerInputC2SPacket(this.sidewaysSpeed, this.forwardSpeed, this.input.jumping, this.input.sneaking));
	final Entity aqa2 = this.getRootVehicle();
	if (aqa2 != this && aqa2.isLogicalSideForUpdatingMovement()) {
		this.networkHandler.sendPacket(new VehicleMoveC2SPacket(aqa2));
	}
}
else {
	this.sendMovementPackets();
}

The problem is that sendMovementPackets() is never called if we are riding a vehicle.

The first part is:

@Inject(at = @At(value = "INVOKE",
	target = "Lnet/minecraft/client/network/AbstractClientPlayerEntity;tick()V",
	ordinal = 0,
	shift = Shift.AFTER), method = "tick()V")

This injects our code right after the "super.tick()" call.

The second part is:

@Inject(at = @At(value = "INVOKE",
	target = "Lnet/minecraft/client/network/ClientPlayerEntity;sendMovementPackets()V",
	ordinal = 0,
	shift = Shift.BY,
	by = 2), method = "tick()V")

This injects our code 2 instructions after the "this.sendMovementPackets()" call, outside of the "else" block.

[github-actions]

This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks.

Pull requests should be closed if:

• They have been superseded by another pull request
• They are out of scope or don't align with the project
• They have become obsolete due to other changes
• They have bugs or conflicts that won't be resolved

[ThisTestUser]

Still relevant. A lot of mods don't work on vehicles (like KillAura), and this mod fixes this.

[github-actions]

This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks.

Pull requests should be closed if:

• They have been superseded by another pull request
• They are out of scope or don't align with the project
• They have become obsolete due to other changes
• They have bugs or conflicts that won't be resolved