Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic - Hunter - Pet Happiness #233

Open
MidnightJay opened this issue Sep 5, 2019 · 19 comments

Comments

@MidnightJay
Copy link

commented Sep 5, 2019

I've searched in the options along with bartender and cannot seem to find a spot to turn on the option for pet happiness for hunters to determine when the pet needs to be fed.

Can you advise where this option is located so I can use this amazing UI for my hunter.

Thanks!

@Wutname1

This comment has been minimized.

Copy link
Owner

commented Sep 5, 2019

What skin are you using it should be on your pets frame

@MidnightJay

This comment has been minimized.

Copy link
Author

commented Sep 5, 2019

I've tried a few (War one currently) and it doesn't show it anywhere on the pet frame that I can find, I disable the UI and it shows just fine.

Do you have a screenshot of where it should be located and maybe that will help me?

Thanks!

@Wutname1

This comment has been minimized.

Copy link
Owner

commented Sep 5, 2019

It should be on the left side of all the frames (War pictured)
image

Addition ref: ae34c8b

@Wutname1

This comment has been minimized.

Copy link
Owner

commented Sep 5, 2019

Do you have your pet out when you load the game? Summon your pet and /reload see if it appears i wonder if there is a bug relating to it updating.

@MidnightJay

This comment has been minimized.

Copy link
Author

commented Sep 5, 2019

I don't have the happiness icon at all. Yes it's out when loading the game, then I stable, reload ui and still have nothing. The icon is missing all together.

I even tried stabling the pet, logging out, logging back in and getting the pet out of the stable and no change

image

@Wutname1

This comment has been minimized.

Copy link
Owner

commented Sep 6, 2019

If one of you are up to helping me test (No hunter atm) I need a hunter to update a file:
https://raw.githubusercontent.com/Wutname1/oUF_PetHappiness/master/oUF_PetHappiness.lua
That file needs to replace your current one at:
World of Warcraft\_classic_\Interface\AddOns\SpartanUI\libs\oUF_PetHappiness

@MidnightJay

This comment has been minimized.

Copy link
Author

commented Sep 6, 2019

updated the file and no change unfortunately .... happiness icon still doesn't show up

@MidnightJay

This comment has been minimized.

Copy link
Author

commented Sep 6, 2019

Let me know if you want me to try testing anything else.

Note I've disabled everything expect for SUI and Bartender and the issue occurs. If you need to redo a complete package with a test name I can install and test it too if you need to.

thanks for taking the time to fix this, SUI is by far my favorite ... possibly ever.

@AlwaysOnTheHunt

This comment has been minimized.

Copy link

commented Sep 8, 2019

Hello.

I have the same issue on my hunter. :( The happiness icon on the pet frame won't show at all. Tried to look at the settings, but no results. I tried to replace the updated file, as MidnightJay where instructed to, and it didn't work sadly. :( Really like SpartanUI, so i hope it will be fixed. Let me know if you need some more hands for testing, would love to help resolve the issue.
Regards! :)

@Wutname1

This comment has been minimized.

Copy link
Owner

commented Sep 9, 2019

So I leveled a hunter to 10 today and I am unable to replicate.

The happiness icon appears on the left of the pet frame on all the skins for me. https://imgur.com/a/BaV2JbK

Try putting this in your chat for me:
/script print(SUI_petFrame.PetHappiness)
You should get a output in your chat of table: <guid>
Example:
image

  • If you get Nil then please run /script print(SUI.IsClassic) let me know if you get true or false.
  • If you get a table then please run /script SUI_petFrame.PetHappiness:Show() and let me know if it appears
@StingMcRay

This comment has been minimized.

Copy link

commented Sep 9, 2019

When i run the script i get this output :
afbeelding

@MidnightJay

This comment has been minimized.

Copy link
Author

commented Sep 9, 2019

I get: table: 00000235A2A78F10

@Wutname1

This comment has been minimized.

Copy link
Owner

commented Sep 9, 2019

You will always get a different table ID (it is random.) Does /script SUI_petFrame.PetHappiness:Show() make it appear?

@MidnightJay

This comment has been minimized.

Copy link
Author

commented Sep 9, 2019

Oh sorry missed that, I was checking while at work lol

So I did that part and no change sadly

image

@MidnightJay

This comment has been minimized.

Copy link
Author

commented Sep 10, 2019

So I was hoping it was due to the updated oUF_PatHappiness.lua file you gave me so I installed the original one again that came with the download and still no change.

I'm at a loss

@Wutname1

This comment has been minimized.

Copy link
Owner

commented Sep 10, 2019

Try these 3 commands me know what happens:

/script print(SUI_petFrame.PetHappiness:IsVisible())
/script SUI_petFrame.PetHappiness:Show()
/script print(SUI_petFrame.PetHappiness:IsVisible())

We are looking to see if the state is changing between true & false after running the Show() command.

@MidnightJay

This comment has been minimized.

Copy link
Author

commented Sep 10, 2019

Just ran the 3 above scripts and the both values return as 'true'
image

@Wutname1

This comment has been minimized.

Copy link
Owner

commented Sep 11, 2019

😢
ok lets try manually clearing where it is and setting it to be below the pet frame.
/script SUI_petFrame.PetHappiness:ClearAllPoints()
/script SUI_petFrame.PetHappiness:SetPoint('TOP', SUI_petFrame, 'BOTTOM', 0, -10)

@MidnightJay

This comment has been minimized.

Copy link
Author

commented Sep 11, 2019

Tried that and no change. Value is still showing true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.