Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Draw Linked Objects" UI name #393

Closed
tkyler opened this issue Oct 13, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@tkyler
Copy link

commented Oct 13, 2018

It looks like the option in the attached screenshot affects the ATTR_draw_disable property. From a developer point of view, "linked objects" is not a term most are familiar with and it took me a while to figure it out(via the hint) as somehow I unchecked it during my workflow and nothing would draw :) Most devs refer to the developer wiki so the nomenclature used there is best applied within blender also if possible. SO.....I would request to alter this to checkbox (checkbox default to OFF) to read one of the options:

NOTE: The hover-tip can be the same for any of the options below:
(hover tip: "Applies ATTR_draw_disable to polygons. All polygons with this material assigned will not be visible in X-Plane. Great for manipulator polygons in the cockpit")

.....and the checkbox string description options:

| | Disable Drawing
| | Disable Drawing of this Material
| | ATTR_draw_disable
| | Exclude from drawing
| | Make polys invisible

I myself like, "Disable Drawing", with a good hover tip.

draw_disable

@tngreene

This comment has been minimized.

Copy link
Collaborator

commented Oct 15, 2018

Fair point! Thank you for your constructive criticism! Linked is also a Blender term, which is weird. I'll think on it and pick from the list or a variation of it.

Design moment: We don't mention OBJ directives in the UI because we want authors to not even have to know what goes inside the OBJ at all. Make it pretty, we handle the file format. Mentioning directives by name is a step back.

Also, if things get deprecated or the 1:1 map is no longer there it creates a problem. For instance, the rules for which GLOBAL_property vs ATTR_property gets expressed have gotten more complicated as the exporter decides for you what you need. If we used OBJ directives by name, we'd have to update the UI more often or people (including ourselves) would be surprised when a checkbox said one thing but did another when it had such a precise label.

"Say what you want to happen, not how it will happen" is a lot more future proof.

@tngreene tngreene added the in review label Oct 15, 2018

@tngreene tngreene self-assigned this Oct 15, 2018

@tngreene

This comment has been minimized.

Copy link
Collaborator

commented May 30, 2019

  1. Draw Objects With This Material
    vs
  2. Draw Linked Objects

1 has 31 characters, but even if cut off "Draw Objects" is still descriptive enough, 2 has 19 characters. Difference of 31-19 is 12 characters. I think it is worth it.

"Print Debug Info To Output, OBJ" is also long, but it works.

Next change I get to change it, I will!

  • Change "Draw Linked Objects" to "Draw Objects With This Material"
  • Update documentation

@tngreene tngreene changed the title Draw Disable GUI Change "Draw Linked Objects" UI name May 30, 2019

@tngreene

This comment has been minimized.

Copy link
Collaborator

commented Jun 10, 2019

Changed with 981585a

tngreene added a commit that referenced this issue Jun 10, 2019

@tngreene tngreene closed this Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.