Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Flash, Strobe, Pulse, or Traffic deprecated Lights crashes exporter #422

Closed
tngreene opened this issue Mar 19, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@tngreene
Copy link
Collaborator

commented Mar 19, 2019

When closing #316 with commit 372132d, a mistake was made:

-        self.color = [blenderObject.data.color[0], blenderObject.data.color[1], blenderObject.data.color[2]]
+        if blenderObject.data.xplane.enable_rgb_override:
+           self.color = blenderObject.data.xplane.rgb_override_values[:]
+        else:
+           self.color = blenderObject.data.color[:]

Color is a tuple, not a list. Any time self.color is attempted to be altered (like with the deprecated non-Default lamps) there is an exception thrown. This wasn't caught at the time because the unit test lights.test.blend only tests the default, named, param, and custom lights!

Very surprisingly, although this behavior is included in 3.5.0-rc_1 and is literally breaking, no one has reached out about. Either this must be extremely underused and ready to be removed for good or people haven't been making a bug. I hope their alternatives have been okay for them.

  • Add to unit
  • Fix this code
  • Merge into v3-5

OR

Kill this off once and for all.

@tngreene tngreene self-assigned this Mar 19, 2019

@tngreene tngreene changed the title Using Flash, Strobe, Pulse, or Traffic deprecated Lights crashes Exporter Using Flash, Strobe, Pulse, or Traffic deprecated Lights crashes exporter Mar 19, 2019

@tngreene

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 20, 2019

Closed with a6733e7

@tngreene tngreene closed this Mar 20, 2019

@tngreene tngreene added the Bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.