Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

280: Fix all the old unit tests #493

Open
tngreene opened this issue Oct 23, 2019 · 2 comments
Open

280: Fix all the old unit tests #493

tngreene opened this issue Oct 23, 2019 · 2 comments

Comments

@tngreene
Copy link
Collaborator

@tngreene tngreene commented Oct 23, 2019

Not only does 2.80 break a lot of stuff, we also have a lot of unit tests that are broken.

  • Make API changes
  • Replace layers related test assertions with exportable root based versions
  • Start varying things up with using collections and root objects

This would also be a nice opportunity I think to tidy things up. This needs to get done before we move past alpha into beta.

@tngreene

This comment has been minimized.

Copy link
Collaborator Author

@tngreene tngreene commented Nov 8, 2019

What shall we do with the

collectBones
collectObjects
vs
collectObjects
collectBones

fiasco?

Do we re-export all those unit test fixtures or do we make the collector switch whether it appends or prepends to match what would have happened.

The later is quicker, but feels wrong.

@tngreene tngreene mentioned this issue Dec 9, 2019
13 of 13 tasks complete
@tngreene

This comment has been minimized.

Copy link
Collaborator Author

@tngreene tngreene commented Dec 9, 2019

Current plan for all the "fixture is broken cause of collectBones/collectObjects disorder.

  1. Change the order in 2.79?
  2. Re-exporter in 2.79 and compare output
  3. If it is okay, copy affected fixtures forward to 2.80

I have a feeling that should work, especially if asking around there was never a clear reason for doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.