Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPM specfile language #327

Merged
merged 3 commits into from Apr 14, 2019

Conversation

Projects
None yet
2 participants
@evitalis
Copy link
Contributor

commented Apr 5, 2019

I was not 100% sure where to add the code to test said file but am happy to add it to this PR after some guidance if desired.

I work pretty regularly with RPMs and figured this would be helpful for myself and others.

@XAMPPRocky

This comment has been minimized.

Copy link
Owner

commented Apr 6, 2019

@evitalis Thank you for your PR! You don't need to add any code you just a comment on the top of the file that says what stats the file should have. You can look at the other files in tests/data such as the rust one for an example.

Also if you could, could you change "line_comment: ["#"] to "base": "hash"? it does functionally the same thing but reduces the amount of code generated at compile time.

@evitalis evitalis force-pushed the evitalis:rpm_specfile branch from 41f72fa to 6cccb0b Apr 8, 2019

@evitalis

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

@XAMPPRocky I went ahead and added the counts. I also squashed my commits to make it a bit cleaner in the history.

@evitalis evitalis force-pushed the evitalis:rpm_specfile branch from 92cce71 to 0dffc8f Apr 8, 2019

@XAMPPRocky

This comment has been minimized.

Copy link
Owner

commented Apr 9, 2019

@evitalis There's a small error in your JSON, "base" is expected to be a single string and not an array. :)

@evitalis

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2019

@XAMPPRocky Sorry for the back and forth hopefully this is in order now. I added a commit fixing the base definition.

@@ -0,0 +1,42 @@
# 43 lines 22 code 4 comments 16 blanks

This comment has been minimized.

Copy link
@XAMPPRocky

XAMPPRocky Apr 11, 2019

Owner

This should be 42 lines.

This comment has been minimized.

Copy link
@evitalis

evitalis Apr 14, 2019

Author Contributor

Fixed

@XAMPPRocky

This comment has been minimized.

Copy link
Owner

commented Apr 14, 2019

Thank you again for your PR and congrats on your first contribution! 🎉

@XAMPPRocky XAMPPRocky merged commit b55653b into XAMPPRocky:master Apr 14, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.