Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix warnings on trait objects without dyn #349

Merged
merged 4 commits into from Jul 19, 2019

Conversation

@lzutao
Copy link
Contributor

commented Jul 18, 2019

No description provided.

@XAMPPRocky

This comment has been minimized.

Copy link
Owner

commented Jul 19, 2019

Thank you for your PR, and congrats on your first contribution!

@XAMPPRocky XAMPPRocky merged commit 5323ca8 into XAMPPRocky:master Jul 19, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lzutao lzutao deleted the lzutao:rustup branch Jul 19, 2019

@lzutao

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

Windows build failed but I don't have mean to test.

@XAMPPRocky

This comment has been minimized.

Copy link
Owner

commented Jul 19, 2019

The windows build failure is unrelated, one of the targets is no longer working due to trust CI issues and I haven't yet devoted the time to fixing or removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.