Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rusty Object Notation #395

Merged
merged 3 commits into from Nov 8, 2019

Conversation

@fkarg
Copy link
Contributor

fkarg commented Oct 28, 2019

fixes #394

@XAMPPRocky

This comment has been minimized.

Copy link
Owner

XAMPPRocky commented Oct 28, 2019

@fkarg Thank you for your PR! Could you also add a test file similar to tests/data/rust.rs in the data folder? You can read more about adding this file in the CONTRIBUTING.md. Once that done and it passes one of the CI platforms, I would be happy to merge it in.

@fkarg

This comment has been minimized.

Copy link
Contributor Author

fkarg commented Nov 5, 2019

travis errors due to the cache being too big (requiring too long to load) - here you go

@XAMPPRocky

This comment has been minimized.

Copy link
Owner

XAMPPRocky commented Nov 5, 2019

@fkarg You need to provide a comment at the top of the file that says what the stats are.

@fkarg

This comment has been minimized.

Copy link
Contributor Author

fkarg commented Nov 5, 2019

Ah I see. Should work now

@XAMPPRocky

This comment has been minimized.

Copy link
Owner

XAMPPRocky commented Nov 8, 2019

Thank you again for your PR and congrats on your first contribution! 🎉

@XAMPPRocky XAMPPRocky merged commit b1d3688 into XAMPPRocky:master Nov 8, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.