From eaf775c86b08b3c05c97c91bd9f9adb4a5eeac18 Mon Sep 17 00:00:00 2001 From: Sergey Date: Fri, 21 Oct 2022 17:03:28 +0200 Subject: [PATCH 1/2] foo #4 Signed-off-by: Matthias Pohl --- .../flink/table/client/gateway/local/LocalExecutorITCase.java | 1 + 1 file changed, 1 insertion(+) diff --git a/flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java b/flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java index 967cb9da21cde..92f06b920fbd8 100644 --- a/flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java +++ b/flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java @@ -586,6 +586,7 @@ private List retrieveChangelogResult( } private void verifySinkResult(String path) throws IOException { + // new comment final List actualResults = new ArrayList<>(); TestBaseUtils.readAllResultLines(actualResults, path); final List expectedResults = new ArrayList<>(); From 0787c5c4c483bf10d71404bd3a57df4c1637189c Mon Sep 17 00:00:00 2001 From: Ryan Skraba Date: Fri, 21 Oct 2022 17:03:56 +0200 Subject: [PATCH 2/2] foo #5 Signed-off-by: Matthias Pohl --- .../apache/flink/runtime/checkpoint/CheckpointCoordinator.java | 1 + 1 file changed, 1 insertion(+) diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java b/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java index 49cc6449b3c6b..993ba22e1fa9a 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java @@ -561,6 +561,7 @@ CompletableFuture triggerCheckpoint( @Nullable String externalSavepointLocation, boolean isPeriodic) { + // aaaand an even better comment CheckpointTriggerRequest request = new CheckpointTriggerRequest(props, externalSavepointLocation, isPeriodic); chooseRequestToExecute(request).ifPresent(this::startTriggeringCheckpoint);